Unable to mark as favorite
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 68/100
Research direction
Start in NotesServerSyncTask.java at pushLocalChanges, especially lines 130 and 150, and trace how marking a note favorite is synchronized. Reproduce the steps on the listed Android and Nextcloud versions, then verify that the star is highlighted and the note appears in both favorite lists without the reported network failure.
Written by the indexing model from the issue text.
Description
This issue respects the following points:
- I have read the FAQ
- I have searched for existing issues
- The issue affects the Notes Android app, neither the Notes server app nor the Nextcloud Android app.
Describe the bug
- Go to Nextcloud notes app
- Mark a note as Favorite (either by pressing on the star, or by entering the note and going to the three dot menu)
- The star is not highlighted and the note does not appear in the list of favorites
Expected behavior
- The 'favorite' star is highlighted
- The note appears at the top of the notes list, where the favorites are listed and under the 'Favorites' category
Notes Android version
35.0.0
Notes server version
6.1.0
Nextcloud Android version
35.0.0
Nextcloud version
34.0.0
Device
Fairphone 5
Android Version
15
App Store
- Google Play Store
- F-Droid
- Huawei App Gallery
Stacktrace
App Version: 35.0.0
App Version Code: 350000090
App Flavor: fdroid
Files App Version Code: 350000090 (PROD)
---
OS Version: 5.4.300-qgki-g148ded19c625(1786725181)
OS API Level: 35
Device: FP5
Manufacturer: Fairphone
Model (and Product): FP5 (FP5)
---
java.lang.Exception: Network connection failed. Please check your internet connection and server URL.[com.nextcloud.android.sso.api.AidlNetworkRequest.performNetworkRequestV2(AidlNetworkRequest.java:179), com.nextcloud.android.sso.api.NextcloudAPI.performNetworkRequestV2(NextcloudAPI.java:159), com.nextcloud.android.sso.helper.Retrofit2Helper$1.execute(Retrofit2Helper.java:53), it.niedermann.owncloud.notes.persistence.NotesServerSyncTask.pushLocalChanges(NotesServerSyncTask.java:130), it.niedermann.owncloud.notes.persistence.NotesServerSyncTask.run(NotesServerSyncTask.java:99), java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:524), java.util.concurrent.FutureTask.run(FutureTask.java:317), java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1156), java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:651), java.lang.Thread.run(Thread.java:1119)]
at it.niedermann.owncloud.notes.persistence.NotesServerSyncTask.pushLocalChanges(NotesServerSyncTask.java:150)
at it.niedermann.owncloud.notes.persistence.NotesServerSyncTask.run(NotesServerSyncTask.java:99)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:524)
at java.util.concurrent.FutureTask.run(FutureTask.java:317)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1156)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:651)
at java.lang.Thread.run(Thread.java:1119)
- Dominant language
- Java
- Stars
- 1.1k
- Forks
- 168
- Avg merge
- 20h 11m
- Merged PRs (30d)
- 28
Getting set up
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from nextcloud/notes-android
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
nextcloud/notes-android#3367 ·
Maintainers usually reply within 1 day
-
0. Needs triage bug
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
nextcloud/notes-android#3353 · 1 comment ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 5/5 Over a week Newbie friendliness 20/100
nextcloud/notes-android#3360 · 1 reaction ·
Maintainers usually reply within 1 day
-
0. Needs triage bug
Difficulty 4/5 3-5 days Newbie friendliness 48/100
nextcloud/notes-android#3358 ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 5/5 Over a week Newbie friendliness 35/100
nextcloud/notes-android#3326 · 1 reaction ·
Maintainers usually reply within 1 day
All issues in nextcloud/notes-android
Similar issues
-
type: possible bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
grimmory-tools/grimmory#2850 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 90/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
aoqia194/leaf-loader#19 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
apache/streampark#4521 ·