Renaming tag do not rename tag's IMAP label
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 48/100
Research direction
Start at MailManager::updateTag() and MailManager::createTag(), tracing how display_name and imap_label are persisted and compared during tag renames and creation. Determine the intended behavior for an existing renamed tag, then add coverage showing that renaming and recreating tags produce the expected distinct entries without breaking existing message labels.
Written by the indexing model from the issue text.
Description
Steps to reproduce
- open the "Edit Tags" modal
- create a new tag "Test"
- rename the just created tag to "Test2"
- create again a new tag "Test"
Expected behavior
"Test" tag appears on the list, together "Test2"
Actual behavior
"Test2" is replicated in the list, and no "Test" is created (even in the database).
Mail app version
5.10
Nextcloud version
No response
Mailserver or service
No response
Operating system
No response
PHP engine version
None
Nextcloud memory caching
No response
Web server
None
Database
None
Additional info
MailManager::updateTag() doesn't update also the imap_label of the tag, which is left unchanged and after an update no longer matches the display_name. Then, in MailManager::createTag(), the tag is checked for existance using imap_label and when the old value is found the method do not proceed, returning data about the old (and then renamed) tag.
I'm not sure about the correct behavior to apply when updating a tag. Should the tag be entirely updated, and existing and tagged messages should be updated to the new permanent flag? Or an allocated imap_label is no longer assignable, and the condition should be handled to stop the user trying to recreate the same label?
- Dominant language
- JavaScript
- Stars
- 1k
- Forks
- 364
- Avg merge
- 1d 4h
- Merged PRs (30d)
- 100
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from nextcloud/mail
-
1. to develop enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
nextcloud/mail#13841 · 3 comments ·
Maintainers usually reply within 1 day
-
1. to develop enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
nextcloud/mail#13828 · 1 comment ·
Maintainers usually reply within 1 day
-
Show email next to name in Search dropdownPossibly taken @vansh-nagar claimed this 23 days ago. Open1. to develop enhancement good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
nextcloud/mail#13703 · 1 comment ·
Maintainers usually reply within 1 day
-
ISO-2022-JP emails are garbled in Mail 5.10.12 [Minimal fix available]Possibly taken @neconohitomi claimed this 43 days ago. Open1. to develop bug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
nextcloud/mail#13472 · 1 comment ·
Maintainers usually reply within 1 day
-
1. to develop technical debt
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day
Similar issues
-
documentation good first issue theming
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
-
feature
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
drevendev/PatchPitch#2 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 65/100
521xueweihan/HelloGitHub#4025 ·