Why does the nginx sidecar mount data and config?
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 55/100
- Issue type
- Refactor
- Clarity
- Mostly clear
- Activity status
- Quiet
- Tech stack
- helm, kubernetes, nginx
- Domain
- devops, infrastructure
Research direction
Start with the nginx sidecar mount definitions and files/nginx.config.tpl, then trace whether the mounted data, config, and /var/www/tmp paths are used. Compare the result with the dataVolumeMount change in #816 and the ownership concern in #335. Done means documenting the need for each mount and updating the chart if any are unnecessary.
Written by the indexing model from the issue text.
Description
The nginx sidecar gets data, config and /var/www/tmp mounted, and I can't work out what it uses them for.
The default server block already refuses both paths (files/nginx.config.tpl):
location ~ ^/(?:build|tests|config|lib|3rdparty|templates|data)(?:$|/) { return 404; }
That's a regex location declared before the static file ones, so it matches first and nginx never touches the filesystem for those URLs. And /var/www/tmp sits outside root /var/www/html, so it isn't reachable at all.
Am I missing a case where nginx actually needs to read them? Asking partly because #816 is adding a dataVolumeMount flag that also applies to the nginx container, and if the mount is never used there then it does not need the flag either. Dropping the three mounts would also mean the internet-facing container no longer has the user data directory attached, and would sidestep the /var/www/html/config ownership trouble in #335.
- Dominant language
- Go Template
- Stars
- 536
- Forks
- 316
- Avg merge
- 4d 16h
- Merged PRs (30d)
- 2
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from nextcloud/helm
-
No native support for REDIS_USER enviroment varPossibly taken @jholmes802 claimed this 6 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
nextcloud.openmetrics.allowedClients is silently ignored unless nextcloud.configs is setPossibly taken @JanWelker claimed this 23 days ago. Open
Difficulty 3/5 1-2 days Newbie friendliness 78/100
-
External Redis not working: redis-session.ini: Permission deniedPossibly taken @antoinetran claimed this 27 days ago. Open
Difficulty 3/5 1-2 days Newbie friendliness 55/100
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
rustyrazorblade/easy-db-lab#1017 ·
Maintainers usually reply within 1 day
-
`automountServiceAccountToken` is in the wrong section of `plugin-site-issue` deployment templateOpenbug plugin-site-issues
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
jenkins-infra/helm-charts#2074 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 85/100
Maintainers usually reply within 1 day
-
helm: Service template renders invalid externalTrafficPolicy: "" for NodePort/LoadBalancerPossibly taken A pull request linked to this issue is open or already merged. Open
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
kubernetes-sigs/headlamp#7950 ·
Maintainers usually reply within 3 days
-
v3.8.0 vanilla manifest points to non-existent images registry.k8s.io/csi-vsphere/csi-vsphere/{driver,syncer}Possibly taken A pull request linked to this issue is open or already merged. Openkind/bug
Difficulty 1/5 1-3 hours Newbie friendliness 85/100
kubernetes-sigs/vsphere-csi-driver#4351 ·
Maintainers usually reply within 1 day