Run the api gates when a diff touches only root build files
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 72/100
- Issue type
- Documentation
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- csharp, github-actions
- Domain
- ci-cd, documentation
Research direction
Start at .claude/agents/test-verifier.md:51, reading the Gates paragraph, the "No gates applicable" bullet and the CI jobs by area table together, then check how the verifier script picks paths from a diff. The change is wording only: name the three root build files (TaskFlow.sln, Directory.Build.props, global.json) as triggering the api jobs plus mcp-integration, narrow the root-files exclusion, widen "Runs when" on the lint, build and test rows, and record what .github/** or .gitignore-only diffs get. Done when a reader can tell from that file alone which gates a root-build-file diff runs.
Written by the indexing model from the issue text.
Description
Follow-up from #521 (docs(pipeline): close gaps in area ownership and gate mapping (#510)), raised during review.
Problem
Root build files (TaskFlow.sln, root Directory.Build.props, global.json) are in no area, and test-verifier reports NO GATES APPLICABLE for a diff with no api, web or assistant path. A brief that changes only one of those files (for example a MicrosoftPlatformVersion bump in Directory.Build.props) therefore reaches the PR with no local lint, build, test or mcp-integration run, although those files drive every api job. The CI jobs by area table notes that TaskFlow.sln also covers root build files, but its api rows run only when the diff touches api, so the note is never reached. CI still catches a failure after the PR opens. Severity: 🟠 Important.
Location
.claude/agents/test-verifier.md:51 at 29b5dfe (permalink)
Suggested approach
Make a diff that touches a root build file run the api jobs and mcp-integration: say so in the verifier's Gates paragraph, narrow "or root files" in its No gates applicable bullet to exclude the three build files, and widen "Runs when" on the lint, build and test rows of the CI table. Decide at the same time what a diff of only .github/** or .gitignore gets. Deferred because the case is rare, it changes behaviour the groomed story for #510 left as "no area", and the fix is larger than the other review fixes.
Created by @nevridge with Claude Code during review of #521
- Dominant language
- C#
- Stars
- 1
- Forks
- 0
- Avg merge
- 2h 43m
- Merged PRs (30d)
- 116
Getting set up
- Ships a Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from nevridge/TaskFlow
-
documentation
Difficulty 1/5 Under an hour Newbie friendliness 90/100
Maintainers usually reply within 1 day
-
pipeline tech-debt
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
All issues in nevridge/TaskFlow
Similar issues
-
needs triage
Difficulty 1/5 Under an hour Newbie friendliness 71/100
Maintainers usually reply within 1 day
-
bug debugger flaky small
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
Maintainers usually reply within 1 day
-
[BUG] MyAnonaMouse search turns a curly apostrophe into a space, so titles with ’ are never foundOpen
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
Maintainers usually reply within 1 day
-
About screenOpenenhancement
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
GDMTT/JiraTaskBar#45 · 2 comments ·
Maintainers usually reply within 1 day
-
HG-3B ISPOpen
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
KSP-RO/RealismOverhaul#3209 · 2 comments ·