[Tracking] Accent colour contrast fixes

Open
  • Is something wrong?
#402 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
css
Domain
accessibility, frontend

Research direction

Start with the linked issues #326, #373, and #374 in the suggested order; the shared stylesheet is index.css, and the affected controls appear on the journal and Tasks pages. Re-measure contrast using computed colours, then check both pages in light and dark mode. Done when all three issues are closed and white-on-accent text meets 4.5:1 in every theme and mode combination.

Written by the indexing model from the issue text.

Description

tech-debt

Groups the accent-colour contrast fixes. They share one new token, --on-accent, and edit the same stylesheet, so they are built in one order.

Suggested order

  1. #326 — Fix the Save button text contrast in the block-reason editor and add the per-theme --on-accent token
  2. #373 — Apply --on-accent to the other white-on-accent sites that fail contrast. Blocked by #326
  3. #374 — Fix the active settings segment button losing its accent background in dark mode. Blocked by #373

Why this order

  • #326 adds the token that #373 applies.
  • #374 was found during the #326 audit and edits .settings-seg-btn in index.css, which #373 also touches. Doing it last means it rebases once.

Notes

  • All three are frontend-only (TaskFlow.Web), so they do not depend on the monorepo move (#397).
  • Contrast figures in #326 and #373 were computed by hand and must be re-measured with computed colours.
  • The journal and Tasks pages both use the controls involved. Check both after each change, in light and dark mode.

Done when

All three are closed, and no white-on-accent text fails 4.5:1 in any theme and mode combination.

Dominant language
C#
Stars
1
Forks
0
Avg merge
2h 2m
Merged PRs (30d)
98

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from nevridge/TaskFlow

All issues in nevridge/TaskFlow

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.