Migration activation Job log ends some outcomes with two periods

Open Beginner friendly
  • Is something wrong?
#164 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
78/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
python
Domain
backend

Research direction

Start by locating the Activate Projects script and the code that formats each activation outcome in the Job log. Check how the outcome text is punctuated, then run the relevant activation tests or reproduce the missing stored revision case described in the issue. Done means each logged outcome ends with one period, while activation results and recorded migration outcomes remain unchanged.

Written by the indexing model from the issue text.

Description

app: scripts severity: low status: backlog type: bug
Plugin Version

v0.0.1

NetBox Version

v4.7.5

Python Version

3.12

Steps to Reproduce
  1. Under Scripts > Migration, stage and validate the built-in Custom Scripts, then complete Enter Cutover.
  2. In a test environment, make a staged Project's stored revision unavailable after validation, for example by removing its stored files from the configured storage backend.
  3. Run Activate Projects and inspect the Job log.
Expected Behavior

Each Project's activation outcome ends with a single period, including when the error message already has one.

For example:

Project deploy could not be activated: The stored revision a1b2c3d4e5f6 is missing.

Observed Behavior

The Job log adds another period to activation errors that already end with one:

Project deploy could not be activated: The stored revision a1b2c3d4e5f6 is missing..

The issue comes from the Job-log message appending a period to the recorded outcome without checking its existing punctuation.

This affects only the Job-log formatting, not the activation result or the recorded migration outcome.

The example uses the revised storage error wording from #150. The same issue exists with the current wording on main.

Dominant language
Python
Stars
8
Forks
0
Avg merge
12h 34m
Merged PRs (30d)
57

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from netbox-community/netbox-scripts

All issues in netbox-community/netbox-scripts

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.