noWeakHash: say the flagged code cannot run

Open
#88 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
58/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
typescript
Domain
devtools

Research direction

Read the noWeakHash rule implementation and its tests, then compare the wording with the verified behavior in docs/verification/results/crypto-hashalg.md (C-008) and the rule policy in docs/adr/0005. Update the message to say the flagged code cannot run, decide from that evidence whether the rule remains a guessing rule and whether string names should match, and add or adjust tests for the chosen behavior.

Written by the indexing model from the issue text.

Description

needs-triage

Runtime verification (PR #85, docs/verification/results/crypto-hashalg.md, C-008) shows crypto.HashAlg.MD5 and SHA1 exist, but createHash rejects both with HASHING_ALGORITHM_IS_NO_LONGER_VALID, by member or by string. The rule only calls them broken. Update the message, and reconsider whether it is still a guessing rule (docs/adr/0005) now that the failure is verified, and whether it should also match the string names.

Dominant language
TypeScript
Stars
1
Forks
0
Avg merge
2h 8m
Merged PRs (30d)
64

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from nemchik/biome-plugin-suitescript

All issues in nemchik/biome-plugin-suitescript

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.