Tool, service and variable get requests omit configured headers
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 88/100
Research direction
Start at ToolServiceVariableBaseQuery.get and compare its request loop with Query.get, Query.results, and Query.hits. Use Requests' send interception to verify configured headers across ToolQuery, ServiceQuery, and VariableQuery, including pagination and empty results. Done means the focused offline cases pass while pagination, output formatting, and HTTP error propagation remain unchanged.
Written by the indexing model from the issue text.
Description
Problem
On develop at 9f7648ccb925b9c0eb50241e35f15d6454e89505, ToolServiceVariableBaseQuery.get omits the configured request headers. The shared implementation affects ToolQuery, ServiceQuery and VariableQuery.
Setting headers through either supported token method, or directly through the public headers mapping, works for the base Query methods but has no effect on the specialized get requests. The request loop supplies only its URL and pagination parameters.
Reproduction
Create any of the three query classes, configure a header, and call get with Requests' send method intercepted. The prepared request does not contain the configured header. This reproduces on every page. No live request is needed.
Expected behavior
Forward the query's headers on every get request, consistent with Query.get, Query.results and Query.hits. Preserve current pagination, output-format handling, empty results and HTTP error propagation.
A focused production fix and 18 offline test cases are prepared. Twelve fail on the original implementation and six controls pass. The complete 147-test suite passes with the fix using the repository-locked HTTP/VCR versions, as do mypy and the repository's gating lint checks. No real credentials or live CMR calls are used.
- Dominant language
- Python
- Stars
- 29
- Forks
- 32
- PR merge metrics
- No merged PRs in 30d
Getting set up
We have not checked this project's setup files yet. Start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from nasa/python_cmr
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
nasa/python_cmr#123 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
nasa/python_cmr#108 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 52/100
nasa/python_cmr#104 ·
-
enhancement
Difficulty 3/5 1-2 days Newbie friendliness 38/100
nasa/python_cmr#95 · 1 comment ·
-
enhancement
Difficulty 3/5 1-2 days Newbie friendliness 45/100
nasa/python_cmr#94 ·
Similar issues
-
ACK_WAITING HELP_WANTED UPDATE_CS
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
OWASP/CheatSheetSeries#2458 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 90/100
BasedHardware/omi#19711 ·
Maintainers usually reply within 1 day
-
Qwen3_5MoeModel no longer returns router_logits, breaking aux loss with output_router_logits=TrueOpen
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
huggingface/transformers#49172 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
vllm-project/vllm-metal#885 ·
Maintainers usually reply within 1 day