Make the reservoir pump-stop scenarios reusable

Open
#348 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 3 days

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
55/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Active
Tech stack
python
Domain
testing

Research direction

Start in the reservoir lifecycle test, where the one- and two-second pump-stop scenarios are currently built, and trace how the random pump command sample is generated. Move that setup into a reusable function that returns the sample, results and histories. Done when both injection times are checked to lie on the simulation time grid and the same sample can be reused across scenarios. The issue is part of #277, so check that tracking issue for context.

Written by the indexing model from the issue text.

Description

Expose the one- and two-second pump stops currently built inside the reservoir lifecycle test. Return the sample, results and histories so users can compare the same random pump commands across scenarios. Check that both injection times are on the simulation grid.

Part of #277.

Dominant language
HTML
Stars
61
Forks
20
Avg merge
2d 13h
Merged PRs (30d)
8

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from nasa/fmdtools

All issues in nasa/fmdtools

Similar issues

More Testing & QA issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.