[BUG] - Incorrect CCSDS 355.0-B-2, 355.1-B-1, 132.0-B-3 and 732.0-B-4 section references in source comments

Open
#567 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
38/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
c
Domain
backend

Research direction

Read the source comments in crypto_key_mgmt.c, crypto_mc.c, crypto_tm.c, crypto_aos.c, and compare the cited clauses with the linked CCSDS Blue Books. Correct the listed section references and typos across the specified comment lines; completion means all listed citations match the documents, leaving the two flagged comments for maintainer review.

Written by the indexing model from the issue text.

Description

Description

Several source comments cite CCSDS Blue Book sections that do not exist, or point at the wrong clause. Comment text only; no behaviour is affected. I intend to work this and will submit pull requests that reference this issue. My Individual CLA was sent to [email protected] on 16 Nov 2026.

  1. CCSDS 355.1-B-1 (SDLS Extended Procedures, Feb 2020), in crypto_key_mgmt.c, crypto_mc.c and crypto_tm.c: references to sections 6.2.x, 7.x and 2.4 for key management, monitoring and FSR. The procedures are in section 5 (for example 5.4 Key Management, 5.4.2.1 Over-the-Air-Rekeying, 5.4.2.2 Key Activation, 5.4.2.6 Key Inventory). 14 comment lines.
  2. CCSDS 355.0-B-2 (SDLS, Jul 2022), in crypto_tm.c: references to 2.4, 3.3, 4.3.x, 6.1.2, 6.3 and 7.2.x (section 4 has only 4.1 and 4.2), plus a "335.0-B-2" typo in crypto_tm.c and crypto_aos.c. 17 comment lines.
  3. CCSDS 132.0-B-3 (TM) and 732.0-B-4 (AOS): the Frame Error Control Field is cited as 4.1.4 (it is 4.1.6) in crypto_tm.c; the Operational Control Field as 4.1.4 (it is 4.1.5) in crypto_aos.c; one Data Field comment is missing its number (4.1.4); and "132.0-B.3" should be "132.0-B-3". 6 comment lines.

Sources: https://ccsds.org/Pubs/355x1b1.pdf, https://ccsds.org/Pubs/355x0b2.pdf, https://ccsds.org/Pubs/132x0b3.pdf, https://ccsds.org/Pubs/732x0b4.pdf

Two further comments (crypto_config.c "Section 7 Management", crypto_error.c "Section 8") have no matching clause in either Blue Book; I have left them for the maintainers to decide.

Branch Name

main

Reproduction steps
  1. Open the files above on main.
  2. Compare each cited section number with the headings in the Blue Books linked above.

Drafted with AI assistance (Claude) and checked against the CCSDS PDFs.

Tausif Ahmed, Founder & CEO, Purplecop Security

Dominant language
C
Stars
178
Forks
70
Avg merge
1h 32m
Merged PRs (30d)
1

Getting set up

  • No Dockerfile or Docker Compose file
  • Has a pull request template
  • No contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from nasa/CryptoLib

All issues in nasa/CryptoLib

Similar issues

More C issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.