bug: move off deprecated `noq_udp::UdpSocketState::send`

Open
#276 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 2 days

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
48/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
rust
Domain
networking

Research direction

Grep netwatch for #[allow(deprecated)] to find the five call sites of noq_udp::UdpSocketState::send, then read the deprecated implementation to see which rate-limited non-WouldBlock logging it did. Decide per call site whether to drop that logging or add a small rate-limiting helper, and run cargo test plus cargo clippy (warnings off for deprecated) to confirm the migration.

Written by the indexing model from the issue text.

Description

netwatch::udp uses the deprecated UdpSocketState::send in 5 places which have all been marked w/ #[allow(deprecated)] + TODO.

The old version of send logged non-WouldBlock errors at a rate limited amount. If we want to keep that behaviour we would have to do add some ratelimiting helper within net watch.

Dominant language
Rust
Stars
34
Forks
56
Avg merge
2d 4h
Merged PRs (30d)
8

Getting set up

  • No Dockerfile or Docker Compose file
  • Has a pull request template
  • No contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from n0-computer/net-tools

All issues in n0-computer/net-tools

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.