semmelei: Dispatch the Procurement to the Bakery as CSV
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 35/100
- Issue type
- Feature
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- typescript
Research direction
Start with parent issue #87 and the decision in #84, then trace the Dispatch and Review Window flow, admin settings API and form, Procurement response, and existing mail and recording sink tests. Check how Item links and position snapshots are represented before planning the grouped CSV and acknowledged delivery. Done means meeting the listed acceptance criteria, including retry behavior and exact attachment bytes.
Written by the indexing model from the issue text.
Description
Parent
#87
What to build
At the Dispatch, semmelei sends the Procurement as a CSV to the Bakery, with a copy to the Nachbarschaftshilfe.
- Settings: Admins enter the Bakery mail address and the copy address (both optional, validated as mail addresses) in the admin settings API and form.
- No Bakery address: the day is skipped and not marked, so it dispatches on the first tick after an address is set. The Procurement response carries a not-dispatched reason (none / no Bakery address) and the page shows "Nicht versendet: keine Bäckerei-Adresse". Note: while no address is set, that day's customers get no confirmations either.
- Bakery order: built from all non-cancelled orders' positions, grouped by the Item's live Bakery Article Number (read through the position's Item link, as decided in #84). Positions of deleted Items or Items without a number are left out entirely. Quantity summed; "Artikel" = distinct name snapshots joined with " / "; "Einzelpreis" = customer price snapshot of the first position; differing prices under one number log a warning.
- CSV: header
Artikel;Artikelnummer;Menge;Einzelpreis,;separator, RFC 4180 quoting where needed, German decimal comma without currency sign (2,50), UTF-8 with BOM, CRLF, sorted by article number, filenamebestellung-<YYYY-MM-DD>.csv, content typetext/csv; charset=utf-8. - Mail: German regardless of order languages, subject
Bestellung Nachbarschaftshilfe für <Wochentag, Datum>, a one-sentence body with the pickup date, the copy address as CC, the CSV attached. - Delivery: with lines, publish and wait for the ack; only then mark the day dispatched. A failed publish leaves it unmarked and the next tick retries (a duplicate order is the lesser failure than a lost one; this is the opposite of the customer mails, which mark before sending, and the reason belongs in a code comment). Without lines, mark dispatched and send no Bakery mail. Confirmations follow as in the Review Window ticket.
- New i18n keys, API client regenerated, rorm migration committed.
Acceptance criteria
- Bakery and copy address settable via API and form; invalid addresses rejected
- No Bakery address: nothing sent, day not marked, Procurement reports the reason and the page shows it; setting the address dispatches on the next tick
- At the Dispatch one mail goes to the Bakery address with the copy address in CC, the German subject and the CSV attached
- CSV: header, one line per article number, joined names, summed quantity,
2,50, BOM, CRLF, sort order; Items without number and deleted Items left out; cancelled orders left out - No Bakery positions: no Bakery mail, day dispatched, confirmations sent
- Failed ack: day not marked, retried next tick; after success no second Bakery mail
- Differing prices under one article number log a warning
- Tests assert the mails leaving the service (recipients, CC, subject, attachment bytes) through the HTTP harness with the recording sink
- Dominant language
- TypeScript
- Stars
- 0
- Forks
- 1
- Avg merge
- 10h 20m
- Merged PRs (30d)
- 36
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from myOmikron/code
-
wayfinder:task
Difficulty 1/5 Under an hour Newbie friendliness 90/100
Maintainers usually reply within 1 day
-
wayfinder:task
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
myOmikron/code#102 · 2 comments ·
Maintainers usually reply within 1 day
-
needs-triage
Difficulty 5/5 Over a week Newbie friendliness 35/100
Maintainers usually reply within 1 day
-
ready-for-agent
Difficulty 5/5 Over a week Newbie friendliness 18/100
Maintainers usually reply within 1 day
-
needs-triage
Difficulty 5/5 Over a week Newbie friendliness 25/100
Maintainers usually reply within 1 day
Similar issues
-
[Bug]: REST API URL starting with "http" but no scheme (e.g. httpbin.org/get) is not given an http:// prefixPossibly taken @ItsDeadlyProgrammer claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
appsmithorg/appsmith#42471 · 1 comment ·
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
ehmpathy/rhachet-roles-bhrain#705 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
Status: Triage
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
mermaid-js/mermaid#8546 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
braintrustdata/braintrust-sdk-javascript#2659 ·
Maintainers usually reply within 1 day