mtg: Editors change the decklist
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 38/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- typescript
- Domain
- backend, frontend, full-stack, testing
Research direction
Start with the collaborators module tests named in the acceptance criteria and trace how Editor and Viewer permissions are handled for deck operations. Map each listed edit and owner operation to its authorization checks and the deck page controls. Done means the criteria pass, including proxy handling, role changes on the next request, and the interaction with deck history issue #145; the payload names no specific files or test commands.
Written by the indexing model from the issue text.
Description
Parent
#155
What to build
An Editor helps build the deck as a decklist. Editors succeed on every edit operation: deck update (name, description, format), colour identity, bracket, rule zero, advisor settings, and card add, import, update and delete including moving cards between zones. They still see the deck through the Share link redaction, so the proxy flag stays the owner's: an Editor's card update leaves an existing proxy flag untouched, an Editor cannot set it, and new slots an Editor adds are no proxy. Every owner operation stays denied for Editors and answers like a missing deck. Viewers stay read-only.
On the deck page, Editors get the editing controls; owner-only controls (collection, sourcing, drift, Visibility, Share link, Collaborator management, folder, delete) stay hidden.
Deck history (#145 and its tickets): an Editor's edits are Deck changes like the owner's; viewing the Deck history, undo, redo, reset and Deck checkpoints stay owner-only. Whichever of the two features lands second adapts to the other; adjust the glossary wording ("what the owner did") accordingly.
Acceptance criteria
- An Editor succeeds on every edit operation listed above, import included
- An Editor's card update leaves an existing proxy flag in place; the proxy flag cannot be set by an Editor; new slots are no proxy
- An Editor is denied every owner operation
- A Viewer is still denied every edit operation
- A level change from Editor to Viewer takes effect on the next request
- Deck page offers Editors the editing controls and hides the owner-only ones
- Tests in the collaborators module
- Dominant language
- TypeScript
- Stars
- 0
- Forks
- 1
- Avg merge
- 10h 20m
- Merged PRs (30d)
- 36
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from myOmikron/code
-
needs-triage
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
wayfinder:task
Difficulty 1/5 Under an hour Newbie friendliness 90/100
Maintainers usually reply within 1 day
-
wayfinder:task
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
myOmikron/code#102 · 2 comments ·
Maintainers usually reply within 1 day
-
needs-triage
Difficulty 5/5 Over a week Newbie friendliness 35/100
Maintainers usually reply within 1 day
-
ready-for-agent
Difficulty 5/5 Over a week Newbie friendliness 18/100
Maintainers usually reply within 1 day
Similar issues
-
bug skills
Difficulty 2/5 1-3 hours Newbie friendliness 77/100
equinor/fusion-framework#5846 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 74/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
Eyevinn/open-videocore#1256 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
[Bug]: Theme preset geist points at undefined --font-geistPossibly taken @claude claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 73/100
Maintainers usually reply within 1 day