Renderer suites flake under CPU load: fixed delays before async state (git-components, file-find-dom, mailbox-inbox-components, others)
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 70/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- electron, typescript
- Domain
- desktop-dev, testing
Research direction
Run node scripts/test-renderer.mjs to reproduce the flaky suites. Locate the test files for git-components, file-find-dom, and mailbox-inbox-components (likely under a renderer test dir) and replace fixed delay() calls with waits for rendered state or attached listeners. Confirm by running the suites alone and under load until they pass consistently.
Written by the indexing model from the issue text.
Description
Found while fixing #802. On a heavily loaded Mac (load average about 40), a full node scripts/test-renderer.mjs run failed these suites on both attempts. None of them mount the Composer or the editor touched in #802:
git-components:environment and branch dropdowns: This Mac(0/2 when run alone). The suite waits a fixeddelay(120)after rendering EnvironmentFooter, before the branch/environment fetch lands.file-find-dom:the Find bar opens(1/2). It dispatches Cmd+F 60 ms after mount, so the window keydown listener's effect may not be attached yet.mailbox-inbox-components: expected 3, got 0 (1/2).git-history-components(0 painted of 150 known),governance-componentsandhtml-preview-componentsfailed in the full run but passed 2/2 when run alone.
These are the same kind of problem as #802: a fixed delay before asserting on state that arrives through an effect or a promise. Fix: wait for the real signal (the rendered state), and for key or click input, wait until the listener or handler is attached.
- Dominant language
- TypeScript
- Stars
- 3
- Forks
- 0
- Avg merge
- 17h 33m
- Merged PRs (30d)
- 163
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from musterhq/muster-code
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
musterhq/muster-code#866 ·
Maintainers usually reply within 1 day
-
p2 type:feature
Difficulty 5/5 Over a week Newbie friendliness 35/100
musterhq/muster-code#843 · 1 comment ·
Maintainers usually reply within 1 day
-
p1 type:feature
Difficulty 5/5 Over a week Newbie friendliness 25/100
musterhq/muster-code#840 ·
Maintainers usually reply within 1 day
-
p1 type:feature
Difficulty 5/5 Over a week Newbie friendliness 30/100
musterhq/muster-code#829 ·
Maintainers usually reply within 1 day
-
type:feature
Difficulty 4/5 3-5 days Newbie friendliness 45/100
musterhq/muster-code#806 ·
Maintainers usually reply within 1 day
All issues in musterhq/muster-code
Similar issues
-
[analytics-core] getQueryParams does not decode `+` as space and truncates values containing `=`Openbug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
amplitude/Amplitude-TypeScript#2179 · 1 comment ·
Maintainers usually reply within 2 days
-
ci good first issue severity: low
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
TMHSDigital/GH-Arcade#111 ·
-
AsnIntegerConverter.toASN coerces strings with +value, rounding integers outside safe-integer rangeOpen
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
PeculiarVentures/asn1-schema#189 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 4 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100