Change debug message level of subtitle lines in libass

Open Beginner friendly
#18,683 4 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
70/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Active
Tech stack
c
Domain
cli

Research direction

Grep the mpv source for '[sub/ass] Event at' and '[sub/ass] forced line break at' to locate the logging calls, likely in sub/ass.c. Change the MP_TRACE macro to MP_DBG for subtitle text lines, or move forced line break logs to another level. Build mpv and verify with --msg-level=sub/ass=debug that the lines show without trace spam.

Written by the indexing model from the issue text.

Description

meta:feature-request
Expected behavior of the wanted feature

Often, because of badly formatted subtitles, there will be multiple subtitles on the screen at the same time. Currently in order to see those you have to use --msg-level=sub/ass=trace. I'd like to request that libass text lines i.e [sub/ass] Event at 248210, +3000: 40,0,Font1_Outline,,64,64,36,,{\an2}I'm saying that if you rush things,\Nyou'll only hurt yourself.\n be printed out at --msg-level=sub/ass=debug or under a different message type. Using trace causes problem because there's often large amounts of spam with [sub/ass] forced line break at #, where # is some number, at the trace level, which makes it hard to see the subtitle lines. These lines appear probably 100x or more than the lines describing the actual text inside the ass file.

Alternative behavior of the wanted feature

Alternatively move the forced line break lines to some other message type as they have nothing to do with the .ass sub files.

Log File

No response

Sample Files

No response

Dominant language
C
Stars
38.2k
Forks
3.7k
Avg merge
1d 13h
Merged PRs (30d)
76

Getting set up

  • No Dockerfile or Docker Compose file
  • Has a pull request template
  • No contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from mpv-player/mpv

All issues in mpv-player/mpv

Similar issues

More C issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.