Change debug message level of subtitle lines in libass
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 70/100
Research direction
Grep the mpv source for '[sub/ass] Event at' and '[sub/ass] forced line break at' to locate the logging calls, likely in sub/ass.c. Change the MP_TRACE macro to MP_DBG for subtitle text lines, or move forced line break logs to another level. Build mpv and verify with --msg-level=sub/ass=debug that the lines show without trace spam.
Written by the indexing model from the issue text.
Description
Expected behavior of the wanted feature
Often, because of badly formatted subtitles, there will be multiple subtitles on the screen at the same time. Currently in order to see those you have to use --msg-level=sub/ass=trace. I'd like to request that libass text lines i.e [sub/ass] Event at 248210, +3000: 40,0,Font1_Outline,,64,64,36,,{\an2}I'm saying that if you rush things,\Nyou'll only hurt yourself.\n be printed out at --msg-level=sub/ass=debug or under a different message type. Using trace causes problem because there's often large amounts of spam with [sub/ass] forced line break at #, where # is some number, at the trace level, which makes it hard to see the subtitle lines. These lines appear probably 100x or more than the lines describing the actual text inside the ass file.
Alternative behavior of the wanted feature
Alternatively move the forced line break lines to some other message type as they have nothing to do with the .ass sub files.
Log File
No response
Sample Files
No response
- Dominant language
- C
- Stars
- 38.2k
- Forks
- 3.7k
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 76
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- No contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from mpv-player/mpv
-
meta:feature-request
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
mpv-player/mpv#18855 · 2 comments ·
Maintainers usually reply within 1 day
-
Subtitle delay value displays "-0ms"May be free again A pull request for this issue was closed without being merged. Openos:linux
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
mpv-player/mpv#18649 · 1 comment ·
Maintainers usually reply within 1 day
-
meta:feature-request
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
mpv-player/mpv#18464 ·
Maintainers usually reply within 1 day
-
Keyboard shortcut next and previous secondary subtitle filePossibly taken @ravarnax claimed this 225 days ago. Openmeta:feature-request
Difficulty 2/5 1-3 hours Newbie friendliness 64/100
mpv-player/mpv#17693 · 5 comments · 1 reaction ·
Maintainers usually reply within 1 day
-
ao/pulse: ao_drain() hangs forever on LoongArch when PulseAudio underrun produces negative buf_diffOpenos:linux
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
mpv-player/mpv#17651 · 1 comment ·
Maintainers usually reply within 1 day
Similar issues
-
`sha256()` returns a wrong hash when libsql-ffi is built with gcc 11 or laterPossibly taken @colinhacks claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
tursodatabase/libsql#2333 ·
Maintainers usually reply within 11 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
OpenPrinting/cups#1826 ·
Maintainers usually reply within 1 day
-
Backport to 3.0 advertises a suffix that does not existPossibly taken A pull request linked to this issue is open or already merged. Open
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
389ds/389-ds-base#8152 ·
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
RetroAchievements/rcheevos#580 · 1 comment ·
Maintainers usually reply within 5 days