'No Firefox binary found at null' with custom path missing .exe (Windows)

Open
#22 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
javascript
Domain
api

Research direction

Reproduce the Windows case with the documented jpm command, then trace how the custom Firefox path is handled when it lacks .exe. Check the error-reporting entry point and verify that the resulting message clearly identifies the supplied path instead of reporting null.

Written by the indexing model from the issue text.

Description

On Windows, if you use a browser path that doesn't end in .exe, you get No Firefox binary found at null. We should probably make this error a little bit more clear.

Here is an example using jpm:

U:\addons\test>jpm run -b "P:\INTERNET\BROWSERS\FF 47"
JPM [info] Starting jpm run on My Jetpack Addon
JPM [info] Creating a new profile
JPM [error] No Firefox binary found at null
JPM [error] Error: spawn P:\INTERNET\BROWSERS\FF 47 ENOENT

The correct command is jpm run -b "P:\INTERNET\BROWSERS\FF 47\firefox.exe"

Originally reported in https://github.com/mozilla-jetpack/jpm/issues/545

Dominant language
JavaScript
Stars
15
Forks
21
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from mozilla/node-fx-runner

All issues in mozilla/node-fx-runner

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.