Existing C-API tests could further verify sample_info.extra_data
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 58/100
- Issue type
- Feature
- Clarity
- Clearly specified
- Activity status
- Stale
- Tech stack
- rust
- Domain
- testing-qa
Research direction
Start with mp4parse_capi/tests/test_fragment.rs around line 103 and review the existing C-API tests for sample_info.extra_data. Compare the checks added by #272, then update the relevant tests so they verify the expected binary data rather than only its length; done means the tests pass with the expected bytes asserted.
Written by the indexing model from the issue text.
Description
#272 adds some test coverage for this in the AV1 case -- we explicitly verify the binary blob exposed via the API is what we expect. There's a little coverage for this in the test_fragment.rs tests too, but they only check the length, rather than the actual data.
We could add some checks to existing tests to make sure the extra data takes on the value we expect. This should be relatively straight forward (particularly if #272 merges and provides prior art).
- Dominant language
- Rust
- Stars
- 448
- Forks
- 72
- Avg merge
- 20d 3h
- Merged PRs (30d)
- 1
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from mozilla/mp4parse-rust
-
Difficulty 4/5 3-5 days Newbie friendliness 48/100
mozilla/mp4parse-rust#444 · 5 comments ·
-
Difficulty 3/5 1-2 days Newbie friendliness 45/100
mozilla/mp4parse-rust#441 ·
-
senc box Open
Difficulty 5/5 Over a week Newbie friendliness 15/100
mozilla/mp4parse-rust#415 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 28/100
mozilla/mp4parse-rust#414 · 4 comments ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 35/100
mozilla/mp4parse-rust#412 · 2 comments ·
All issues in mozilla/mp4parse-rust
Similar issues
-
bug CLI custom-model
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
rust-bitcoin/rust-bitcoin#6930 · 1 comment ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
fulcrumgenomics/ferro-hgvs#2251 ·
-
A-allocators A-docs C-enhancement T-libs
Difficulty 2/5 1-3 hours Newbie friendliness 75/100