Granular control options for included holidays
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 30/100
- Issue type
- Feature
- Clarity
- Needs clarification
- Activity status
- Stale
- Tech stack
- python
- Domain
- machine-learning
Research direction
Start by reading mozaic/holidays.py around line 37 and inspect how included holidays and any extra-holiday support are currently represented. Determine the intended interface for adding holidays and excluding them globally or for a specific year; done means counterfactual analyses can apply those controls without breaking existing forecasting behavior.
Written by the indexing model from the issue text.
Description
This is much more of a stretch feature, but there were two different aspects that came up in recent analyses for trying to investigate model anomalies.
- The ability to add in extra holidays for an analysis -- which I believe has started implementation but might not be properly functional yet
- The ability to exclude certain holidays -- either in general or in a specific year -- to run counterfactual analyses
(2) in particular is less important if other model performance and quantification features are more easily available, but it may still be useful in some cases where certain holidays have unexpected strange patterns associated in given years.
This approach could potentially also allow custom flagging of known historical anomalies that might distort forecasting, but the approach there might instead be to encourage additional contributions to the actual implementation of known anomalies as holidays here: https://github.com/mozilla/mozaic-forecasting/blob/2becad6a9b372c8f0d732f91ee92f6b8d7b06fed/mozaic/holidays.py#L37
- Dominant language
- Python
- Stars
- 3
- Forks
- 3
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from mozilla/mozaic-forecasting
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
-
Difficulty 5/5 Over a week Newbie friendliness 35/100
-
Difficulty 5/5 Over a week Newbie friendliness 30/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 45/100
All issues in mozilla/mozaic-forecasting
Similar issues
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
topoteretes/cognee#5647 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
Sendspin/sendspin-python-cli#291 ·
Maintainers usually reply within 6 days
-
Assertion-shape guard fails on development: vacuous recorded-iteration assertion in the assetLinks batch_get helper testPossibly taken A pull request linked to this issue is open or already merged. Openbug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
awslabs/visual-asset-management-system#414 ·
Maintainers usually reply within 1 day
-
bug v1 v2
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
modelcontextprotocol/python-sdk#3670 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
aicell-lab/bioengine#232 ·
Maintainers usually reply within 1 day