Do not hardcode GitHub URLs and branch-to-repo mappings; resolve them from Phabricator
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 55/100
Research direction
Start by comparing the duplicated mappings and URLs in agents/build-repair/hackbot_agents/build_repair/resolve.py, agents/test-repair/hackbot_agents/test_repair/resolve.py, and agents/test-repair/hackbot_agents/test_repair/notify.py, along with each agent's hackbot.toml. Read the referenced Phabricator repository URI configuration first. Done means these values are resolved from Phabricator rather than maintained as duplicate hardcoded mappings or templates.
Written by the indexing model from the issue text.
Description
agents/build-repair/hackbot_agents/build_repair/resolve.py and agents/test-repair/hackbot_agents/test_repair/resolve.py each independently hardcode an identical branch-to-repo-path map (autoland, mozilla-central, try, etc.) plus Taskcluster/Lando/hg URLs, and agents/test-repair/hackbot_agents/test_repair/notify.py hardcodes a GitHub commit URL template. Every agent's hackbot.toml also hardcodes repo_url.
Look these up from Phabricator's own repository configuration instead (see for example https://phabricator-dev.allizom.org/source/ff-test-autoland-dev/manage/uris/), so branch names always match what is actually configured on Phabricator rather than a second hardcoded copy.
- Dominant language
- Python
- Stars
- 571
- Forks
- 355
- Avg merge
- 2d 2h
- Merged PRs (30d)
- 78
Getting set up
- Ships a Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from mozilla/bugbug
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
hackbot
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
Maintainers usually reply within 1 day
-
Install `xvfb` in the image for the bug fix agentPossibly taken @ayoubdiourin7 claimed this 5 days ago. Openhackbot
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
mozilla/bugbug#6947 · 1 assignee ·
Maintainers usually reply within 1 day
-
good-first-bug hackbot
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
good-first-bug hackbot
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
mozilla/bugbug#6918 · 5 comments ·
Maintainers usually reply within 1 day
Similar issues
-
adr
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
kristofdegrave/homeassistant-smart-charging#1607 ·
Maintainers usually reply within 1 day
-
namespace operations
Difficulty 2/5 1-3 hours Newbie friendliness 64/100
EclipseFdn/open-vsx.org#13665 ·
Maintainers usually reply within 1 day
-
doc good first issue help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
collective/icalendar#1865 · 2 comments ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
canonical/opentelemetry-collector-operator#409 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 85/100
mozilla/addons-release-tests#1243 ·
Maintainers usually reply within 1 day