[not_landed] Clear BugBot needinfos when prompted patches land on an open bug
Maintainers usually reply within 4 days
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 48/100
Research direction
Start with the status-based cleanup described in #3003 and #3004, and trace how BugBot-created not_landed needinfos are matched to patches. Define a reliable match using information from the original bot comment, then add coverage for multiple prompted patches, later or obsolete attachments, missing revisions, unrelated flags, and patches that are later backed out.
Written by the indexing model from the issue text.
Description
Follow-up to #3003, whose initial scope is cleanup on bugs closed as FIXED in #3004.
A patch can land while its Bugzilla bug stays open. In that case, a not_landed needinfo about that patch is no longer actionable, but the status-based cleanup does not remove it.
Clear pending needinfo flags created by not_landed once all patches that prompted that particular request have landed, even if the bug remains open. Leave human-created needinfos and flags created by other BugBot rules untouched.
The key design question is how to identify the original patches reliably. Current attachments alone are insufficient: unrelated patches may be added later, and original attachments may become obsolete. One option to evaluate is including explicit revision links in the original needinfo comment, allowing cleanup to check the patches named in the matching bot comment without custom database tracking. Historical comments without that information should not be cleared based on guesses.
Include coverage for multiple prompted patches, later unrelated attachments, obsolete attachments, missing/inaccessible revisions, and unrelated flags. The design should also consider patches that land and are subsequently backed out.
This is distinct from #2404, which concerns arbitrary pending needinfos on closed bugs.
- Dominant language
- Python
- Stars
- 69
- Forks
- 93
- Avg merge
- 3d 11h
- Merged PRs (30d)
- 19
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- No contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from mozilla/bugbot
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
Maintainers usually reply within 4 days
-
AttributeError: 'list' object has no attribute 'values'Possibly taken @SAY-5 claimed this 41 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 4 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 4 days
-
Difficulty 3/5 1-2 days Newbie friendliness 68/100
mozilla/bugbot#3010 · 1 comment ·
Maintainers usually reply within 4 days
-
[user_activity] TypeError: string indices must be integersMay be free again @suhaibmujahid claimed this 48 days ago, and no pull request is open. Open
mozilla/bugbot#2995 · 1 assignee ·
Maintainers usually reply within 4 days
Similar issues
-
needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Maintainers usually reply within 1 day
-
json_params_matcher fails on falsy top-level JSON primitives (0, False, "")Possibly taken @mayureshsonawane17 claimed this today. OpenWaiting for: Product Owner
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Maintainers usually reply within 5 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Maintainers usually reply within 1 day
-
Add .devin pluginOpen
Difficulty 1/5 Under an hour Newbie friendliness 88/100
ayghri/i-have-adhd#249 ·
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
modelscope/FunASR#3762 ·
Maintainers usually reply within 1 day