Enforce stricter offset parsing
Maintainers usually reply within 1 day
Nobody has claimed this yet.
- #494 by @fzzzy — closed without merging
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 52/100
Research direction
Start by tracing offset handling in the Rust service and inspect the db-tests get_bsos_limit_offset change from #368, using Python syncstorage's stricter behavior as the reference. Verify the handling for sort=index with timestamp-bound tokens and other sort types with plain numeric offsets; done means both invalid forms are rejected with InvalidOffsetError.
Written by the indexing model from the issue text.
Description
A followup to #368: Python syncstorage has stricter handling of offset values, raising an InvalidOffsetError when:
- a special "offset token" (
timestamp_bound:offsetformat) is specified forsort=index - a regular offset (just a plain numeric
offsetvalue) for other sort types
The change to db-tests' get_bsos_limit_offset in #368 somewhat came across case #1: the fact that passing a timestamp bound to sort=index is bogus.
Allowing case #2 made sense for the sake of deploying #368 (so a client w/ a plain offset retrieved from just before its deployment would continue working after the deployment). Now that it's deployed we could begin rejecting it also.
- Dominant language
- Rust
- Stars
- 1.8k
- Forks
- 87
- Avg merge
- 1d 9h
- Merged PRs (30d)
- 62
Getting set up
- Ships a Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from mozilla-services/syncstorage-rs
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
mozilla-services/syncstorage-rs#2715 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
mozilla-services/syncstorage-rs#2714 ·
Maintainers usually reply within 1 day
-
Android AppOpen
Difficulty 4/5 3-5 days Newbie friendliness 25/100
mozilla-services/syncstorage-rs#2706 ·
Maintainers usually reply within 1 day
-
Difficulty 3/5 1-2 days Newbie friendliness 54/100
mozilla-services/syncstorage-rs#2696 ·
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
mozilla-services/syncstorage-rs#2653 ·
Maintainers usually reply within 1 day
All issues in mozilla-services/syncstorage-rs
Similar issues
-
area:docs documentation good first issue priority:medium
Difficulty 1/5 Under an hour Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
feature
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
calagopus/panel#285 · 1 comment ·
Maintainers usually reply within 1 day
-
[Bug]: streamed Responses API flex_unavailable error maps to 500 InternalServerError instead of 429Openllm translation
Difficulty 2/5 Under an hour Newbie friendliness 85/100
BerriAI/litellm#49736 · 1 comment ·
Maintainers usually reply within 1 day
-
question
Difficulty 1/5 Under an hour Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
autoindex tests: denied loopback bind shows only PermissionDenied (255 failures), not the causeOpenfield-report
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
Maintainers usually reply within 1 day