🚨 Transformers v5.23.0 removes `ProcessingKwargs._defaults` which is used by Qwen-Omni / Gemma3
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 68/100
Research direction
Start with the referenced code in swift/template/templates/qwen.py lines 884–896 and swift/template/templates/gemma.py line 123. Check how these processors read or write ProcessingKwargs._defaults and compare with the processor defaults described in the issue. Update the affected usage for the Transformers change, then verify Qwen-Omni and Gemma3 processor behavior.
Written by the indexing model from the issue text.
Description
Checklist / 检查清单
- I have searched existing issues, and this is a new question or discussion topic. / 我已经搜索过现有的 issues，确认这是一个新的问题与讨论。
Question Description / 问题描述
Hi, just wanted to give you a heads up that we'll be removing ProcessingKwargs._defaults from transformers v5.23.0 on (https://github.com/huggingface/transformers/pull/49089).
Transformers processor kwargs will no longer have defaults defined in _defaults, so reading from or writing to the defaults will no longer work. Instead the defaults are now defined directly on the processor class instead.
The following lines in ms-swift might be impacted:
- https://github.com/modelscope/ms-swift/blob/47b437a84e9ea481dbe24f516fc2318e7faf94da/swift/template/templates/qwen.py#L884-L886
- https://github.com/modelscope/ms-swift/blob/47b437a84e9ea481dbe24f516fc2318e7faf94da/swift/template/templates/qwen.py#L887-L896
- https://github.com/modelscope/ms-swift/blob/47b437a84e9ea481dbe24f516fc2318e7faf94da/swift/template/templates/gemma.py#L123
Sorry for the inconvenience, as mentioned above the defaults can now be read from the processor directly. The default['audio_kwargs']['truncation'] = False should also not be necessary any more as this default has been updated in transformers since a while.
- Dominant language
- Python
- Stars
- 16.1k
- Forks
- 1.8k
- Avg merge
- 1d 17h
- Merged PRs (30d)
- 70
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from modelscope/ms-swift
-
[Bug] `get_seed` consumes a draw from the shared RandomState even when decision augmentation is disabled, changing the train/val split and dataset shufflePossibly taken @ryznren claimed this 12 days ago. Openbug
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
modelscope/ms-swift#10466 · 1 comment ·
Maintainers usually reply within 1 day
-
[Bug] `swift --help` raises KeyError instead of showing CLI helpPossibly taken @haahy claimed this 38 days ago. Openbug
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
modelscope/ms-swift#10287 ·
Maintainers usually reply within 1 day
-
[Bug] find_free_port() reports the last busy port as free when its scan window is exhaustedPossibly taken @Lesereingrape claimed this 42 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
modelscope/ms-swift#10263 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
modelscope/ms-swift#10095 · 1 comment ·
Maintainers usually reply within 1 day
-
bug
Difficulty 4/5 3-5 days Newbie friendliness 42/100
modelscope/ms-swift#10543 ·
Maintainers usually reply within 1 day
All issues in modelscope/ms-swift
Similar issues
-
area: providers/aws priority: p2 size: S type: bug type: testing
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
finos/open-resource-broker#851 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 1-3 hours Newbie friendliness 88/100
sandialabs/atlas-ui-3#1196 ·
Maintainers usually reply within 1 day
-
enhancement triage
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
ShaftHQ/SHAFT_ENGINE#7902 ·
Maintainers usually reply within 1 day
-
[Bug]: GraphML export writes invalid XML when a value contains a control character (e.g. form feed)Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
topoteretes/cognee#6646 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 75/100
DOI-USGS/pywatershed#428 ·