Reject `subscriptions/listen` without `notifications`
Maintainers usually reply within 1 day
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 68/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- java
- Domain
- backend-api-design
Research direction
Start by locating SubscriptionsFeature and tracing how it parses subscriptions/listen parameters, then check nearby tests for malformed subscription requests. Add coverage for missing and null notifications being rejected while {} remains valid, and confirm the response is -32602 (and HTTP 400 where applicable).
Written by the indexing model from the issue text.
Description
Spec:
- Schema:
SubscriptionsListenRequestParams(notifications: SubscriptionFilteris a required field) - Subscriptions: Opening a Stream
Current behavior
If notifications is missing or null, SubscriptionsFeature treats it as an empty filter, acknowledges the subscription and keeps an idle stream open.
Proposal
Answer with -32602 Invalid params (400 on HTTP), as for other malformed params. An explicit empty object {} stays valid.
- Dominant language
- Java
- Stars
- 3.7k
- Forks
- 1.2k
- Avg merge
- 7h 34m
- Merged PRs (30d)
- 46
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from modelcontextprotocol/java-sdk
-
HttpServletStreamableServerTransportProvider: GET stream sends no status or headers until the first eventPossibly taken @karthiksenv claimed this 19 days ago. Openarea/server area/transport P3
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
modelcontextprotocol/java-sdk#1155 ·
Maintainers usually reply within 1 day
-
Client request handlers that complete empty send no JSON-RPC responsePossibly taken @1fanwang claimed this 49 days ago. Openarea/client bug P2
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
modelcontextprotocol/java-sdk#1124 · 5 comments ·
Maintainers usually reply within 1 day
-
ServerCapabilities.logging is added unconditionally, overriding the caller's explicit capabilitiesPossibly taken @1yuxiangJ claimed this 64 days ago. Openbug P2 ready for work
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
modelcontextprotocol/java-sdk#1086 · 1 comment ·
Maintainers usually reply within 1 day
-
Reject listRoots if not supported by client, without sending any requestPossibly taken @nikita-kibitkin claimed this 88 days ago. Openenhancement good first issue P3
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
modelcontextprotocol/java-sdk#1067 · 2 comments ·
Maintainers usually reply within 1 day
-
StdioClientTransport missing explicit UTF-8 charset in InputStreamReader (same issue as #295, but on client side)Possibly taken @suryateja-g13 claimed this 159 days ago. Openbug P2 ready for work
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
modelcontextprotocol/java-sdk#898 · 1 comment ·
Maintainers usually reply within 1 day
All issues in modelcontextprotocol/java-sdk
Similar issues
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 61/100
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
ReChronoRain/HyperCeiler#1743 ·
Maintainers usually reply within 6 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
ControlSystemStudio/phoebus#3979 ·
Maintainers usually reply within 2 days
-
Cannot find symbol CTypedefPossibly taken @pellico claimed this today. Openbug
Difficulty 1/5 Under an hour Newbie friendliness 82/100