Tools registered with WithTools keep a disposed service provider in memory
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 58/100
Research direction
Start by running the provided reproduction with WithTools both with and without per-app JsonSerializerOptions, then trace CreateAIFunctionFactoryOptions through AIFunctionFactory and the McpJsonUtilities.DefaultOptions cache. Done means disposed service providers become collectible in both cases, confirmed by the WeakReference and GC checks in the reproduction.
Written by the indexing model from the issue text.
Description
Describe the bug
A service provider that creates its tools through WithTools or WithToolsFromAssembly stays in memory for the life of the process, even after it's disposed.
CreateAIFunctionFactoryOptions hands AIFunctionFactory a ConfigureParameterBinding lambda that captures the McpServerToolCreateOptions, and with them the Services these registrations pass in. Microsoft.Extensions.AI caches the descriptor of each tool method in a static ConditionalWeakTable keyed by the serializer options, and that lambda is part of the key of every entry. Unless serializer options are passed, they're McpJsonUtilities.DefaultOptions, which never go away. So each service provider adds entries that no later lookup can match, since the lambda is new every time, and each entry keeps its provider alive. Only the cache's limit of 512 entries puts a cap on it.
An app with a single service provider won't notice. A test project that starts an app per test does. In a dump of ours, this held 67 of the 110 disposed service providers.
To Reproduce
ModelContextProtocol 2.2.0 and Microsoft.Extensions.DependencyInjection 10.0 on net10.0:
using System.ComponentModel;
using System.Runtime.CompilerServices;
using System.Text.Json;
using Microsoft.Extensions.DependencyInjection;
using ModelContextProtocol;
using ModelContextProtocol.Server;
var ownOptions = args.Contains("--own-serializer-options");
List<WeakReference> providers = [];
for (var i = 0; i < 20; i++)
providers.Add(await CreateAndDispose(ownOptions));
for (var i = 0; i < 3; i++)
{
GC.Collect();
GC.WaitForPendingFinalizers();
}
Console.WriteLine($"own serializer options: {ownOptions}, {providers.Count(p => p.IsAlive)} of {providers.Count} disposed service providers are still alive");
[MethodImpl(MethodImplOptions.NoInlining)]
static async Task<WeakReference> CreateAndDispose(bool ownOptions)
{
var services = new ServiceCollection();
if (ownOptions)
services.AddMcpServer().WithTools<EchoTools>(new JsonSerializerOptions(McpJsonUtilities.DefaultOptions));
else
services.AddMcpServer().WithTools<EchoTools>();
await using var provider = services.BuildServiceProvider();
_ = provider.GetServices<McpServerTool>().ToList();
return new WeakReference(provider);
}
[McpServerToolType]
public sealed class EchoTools
{
[McpServerTool, Description("Echoes the message back.")]
public string Echo(string message) => message;
}
Output:
own serializer options: False, 20 of 20 disposed service providers are still alive
own serializer options: True, 0 of 20 disposed service providers are still alive
Expected behavior
A disposed service provider can be collected, whether or not serializer options were passed.
Additional context
The path from our dump:
McpJsonUtilities.DefaultOptions
> ConcurrentDictionary<DescriptorKey, ReflectionAIFunctionDescriptor>
> Func<ParameterInfo, ParameterBindingOptions>
> AIFunctionMcpServerTool+<>c__DisplayClass4_0
> McpServerToolCreateOptions
> ServiceProviderEngineScope
Giving each app its own copy of the serializer options, as the second run above does, works around it for now.
- Dominant language
- C#
- Stars
- 4.6k
- Forks
- 849
- Avg merge
- 1d 16h
- Merged PRs (30d)
- 24
Getting set up
Starts the project's dev container in your browser, under your own GitHub account.
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from modelcontextprotocol/csharp-sdk
-
Difficulty 1/5 Under an hour Newbie friendliness 88/100
modelcontextprotocol/csharp-sdk#2031 ·
Maintainers usually reply within 1 day
-
Static resources whose URIs differ only in the fragment or user info collapse into onePossibly taken @halter73 claimed this 10 days ago. OpenP2
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
modelcontextprotocol/csharp-sdk#1970 · 4 comments · 1 assignee ·
Maintainers usually reply within 1 day
-
POST /mcp with a missing or unparseable Content-Type returns HTTP 500 instead of a 4xxPossibly taken @halter73 claimed this 10 days ago. Openbug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
modelcontextprotocol/csharp-sdk#1966 · 5 comments · 1 assignee ·
Maintainers usually reply within 1 day
-
Reserved URI-template expansion throws for supplementary Unicode charactersPossibly taken @tarekgh claimed this 3 days ago. OpenP3
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
modelcontextprotocol/csharp-sdk#1913 · 1 comment · 1 assignee ·
Maintainers usually reply within 1 day
-
ClaimsPrincipal parameter injection sample requestPossibly taken @utsavjain2809 claimed this 48 days ago. Openhelp wanted P3
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
modelcontextprotocol/csharp-sdk#1899 ·
Maintainers usually reply within 1 day
All issues in modelcontextprotocol/csharp-sdk
Similar issues
-
CLI: stale build hint, non-gofmt autocomplete output and a leftover `--revit=<year>` in the docsOpenCommand Line Utility (CLI)
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
pyrevitlabs/pyRevit#4217 ·
Maintainers usually reply within 1 day
-
area: ui bug ready
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
Maintainers usually reply within 1 day
-
account bug effort:S P2
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
nightscout/nocturne#3745 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
grate-devs/grate#969 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
jsboige/CoursIA#27768 · 2 comments ·
Maintainers usually reply within 1 day