Bleach is deprecated
Maintainers usually reply within 3 days
@seansica is already working on this.
Since Jun 28, 2023.
Assessment
This issue has not been assessed yet.
Description
Per Mozilla, as of Jan 23, Bleach is deprecated: https://github.com/mozilla/bleach/issues/698#issue-1553425406
They will continue to provide security updates and bug fixes for approximately one year.
We need to replace Bleach.
ammonia looks like a promising solution but there may be others.
This is a good opportunity to refactor a bit. The process of sanitizing the HTML and generating the seed file (index.json) for the search index should be decoupled. There ought to be a separation of concerns between the generation of the website content and the generation of the search index.
Order of events:
- Build website (Pelican/update-attack.py)
- Generate seed file for search index (e.g., ammonia)
- Generate search index (attack-search --> npm/webpack)
- Dominant language
- HTML
- Stars
- 590
- Forks
- 175
- Avg merge
- 2d 7h
- Merged PRs (30d)
- 3
Getting set up
- Ships a Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from mitre-attack/attack-website
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
mitre-attack/attack-website#628 · 1 comment ·
Maintainers usually reply within 3 days
-
Difficulty 3/5 1-2 days Newbie friendliness 45/100
mitre-attack/attack-website#626 ·
Maintainers usually reply within 3 days
-
Difficulty 3/5 1-2 days Newbie friendliness 52/100
mitre-attack/attack-website#596 ·
Maintainers usually reply within 3 days
-
Difficulty 3/5 1-2 days Newbie friendliness 55/100
mitre-attack/attack-website#571 · 2 comments · 1 reaction ·
Maintainers usually reply within 3 days
-
[Accessibility] Navbar logo missing alt text causing WCAG violationMay be free again @jondricek claimed this 234 days ago, and no pull request is open. Open
mitre-attack/attack-website#563 · 1 assignee ·
Maintainers usually reply within 3 days