Hacktoberfest 2026: the issues maintainers tagged for October, open and beginner-friendly. Browse Hacktoberfest issues

module templates incorrectly assume external_reference will follow S-Code and G-Code conventions and case

Open
  • Is something wrong?
#381 1 comment 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 3 days

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
35/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
html
Domain
frontend

Research direction

Start with modules/groups/templates/group-index.html around line 47, where the groups table builds links from row.id. Compare the href with the displayed label and verify generation using an external ID such as MyCustomNotUpperCaseCode; done means the generated card links to the matching case-sensitive directory while the label remains appropriate.

Written by the indexing model from the issue text.

Description

BLUF:

please drop the use the "|upper" in creation of the href in a table's card element.

When customizing STIX objects for use by the attack-website generation on our internal site, we discovered that the pelican templates for groups (specifically, but elsewhere as well) are inconsistent when creating the cards for groups and other tables.

For the display name, upper case by default may be appropriate for table uniformity of appearance. Unfortunately, forcing the href to use a specific case or perhaps use a different URL can result in an invalid URL.

For example from the enterprise ATTACK:
...

"external_references": [
    {
        "source_name": "mitre-attack",
        "external_id": "G0001",
        "url": "https://attack.mitre.org/groups/G0001"
    },
....
    "name": "Axiom",
....

The site generation code will create a directory /groups/G0001.
And the ID field for the card in the group table will look like:

<td>
    <a href="/groups/G0001"> G0001 </a>
</td>

That comes from the group-index.html template in modules/groups/templates, specifically starting at line 47:

                            <tbody>
                                {% for row in parsed.groups_table %}
                                    <tr>
                                        <td>
                                            <a href="/groups/{{row.id|upper}}"> {{row.id|upper}} </a>
                                        </td>
                                        <td>
                                            <a href="/groups/{{row.id|upper}}"> {{row.name}} </a>
                                        </td>

Note the "|upper" directive

The problem comes, when the ID case may not natively be upper

for example an intrusion set named "SomeFineGroupName" has an external reference appears as:

{
    "source_name": "mitre-attack",
    "url": "https://my-attack-website.myorg.com/groups/MyCustomNotUpperCaseCode"
    "external_id": "MyCustomNotUpperCaseCode"
}

The resulting directory entry will be generated as /group/MyCustomNotUpperCaseCode, matching the ID in the stix object.
The resulting card for the groups table however, will result in an ref such as:

<td>
    <a href="/groups/MYCUSTOMNOTUPPERCASECODE"> MYCUSTOMNOTUPPERCASECODE </a>
</td>

The solution is to drop the "|upper" directive in the href, while keeping the label as is if desired.

Dominant language
HTML
Stars
590
Forks
175
Avg merge
2d 7h
Merged PRs (30d)
3

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from mitre-attack/attack-website

All issues in mitre-attack/attack-website

Similar issues

More Web Dev issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.