nsys-ds41: self-test stub tree omits gate-bound.sh

Closed Beginner friendly
#466 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
90/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
shell

Research direction

Inspect the self-test that builds the temporary tree and the startup sourcing in tools/ref/nsys-ds41.sh; the missing entry point is tools/gate-bound.sh. Copy that file into the stub tree's tools directory before invoking the runner, then rerun the self-test and confirm the ok, cap, gone, and journal cases reach their expected exit codes.

Written by the indexing model from the issue text.

Description

review-bot

The self-test copies nsys-ds41.sh into a temporary tree without tools/gate-bound.sh. The copied runner sources that file at startup and exits 70 before any two-card check runs. The ok, cap, gone and journal cases expect exit codes 42, 78, 69 and 69, so all four fail before reaching their intended paths. Copy tools/gate-bound.sh into the stub tree's tools directory before invoking the runner, then rerun the self-test.

Evidence (at the base of #465):

Filed by Shingler, the review bot, while reviewing #465; the defect is outside that pull request.

Dominant language
Rust
Stars
21
Forks
4
Avg merge
2h 31m
Merged PRs (30d)
828

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from midagedev/bloomery

All issues in midagedev/bloomery

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.