ref tools: tensor filename normalization has two owners
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 66/100
Research direction
The duplicated slash, backslash and space replacement lives in tools/ref/set-diff.py near line 53 and tools/ref/check-int-twins.py near line 72. Compare both copies, then find where set-diff.py line 79 and check-int-twins.py lines 122-133 use them. The shared rule should move into tools/bloomery/manifest.py, which both scripts already import. Done when both tools call that one function and still produce the same tensor filenames.
Written by the indexing model from the issue text.
Description
set-diff.py:53 and check-int-twins.py:72 contain the same slash, backslash and space replacement rule. Both derive dumped tensor filenames from manifest names. set-diff.py:79 uses it for f32 files; check-int-twins.py:122-133 uses it for integer twins and their f32 counterparts. This duplicates one filename contract. Both tools already import tools/bloomery/manifest.py. Move the rule there and call it from both tools.
Evidence (at the base of #132):
Filed by Shingler, the review bot, while reviewing #132; the defect is outside that pull request.
- Dominant language
- Rust
- Stars
- 21
- Forks
- 4
- Avg merge
- 2h 36m
- Merged PRs (30d)
- 498
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from midagedev/bloomery
-
model
Difficulty 5/5 Over a week Newbie friendliness 25/100
midagedev/bloomery#698 · 3 comments ·
Maintainers usually reply within 1 day
-
model
Difficulty 5/5 Over a week Newbie friendliness 25/100
Maintainers usually reply within 1 day
-
model
Difficulty 5/5 Over a week Newbie friendliness 25/100
midagedev/bloomery#632 · 7 comments ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 4/5 1-2 days Newbie friendliness 45/100
midagedev/bloomery#617 · 1 comment ·
Maintainers usually reply within 1 day
-
enhancement tracking
Difficulty 5/5 Over a week Newbie friendliness 25/100
midagedev/bloomery#609 · 4 comments ·
Maintainers usually reply within 1 day
All issues in midagedev/bloomery
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
farion1231/cc-switch#8829 ·
Maintainers usually reply within 1 day
-
bug ci good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 92/100
longbridge/gpui-kit#3677 ·
Maintainers usually reply within 1 day
-
E-pr-welcome
Difficulty 2/5 1-3 hours Newbie friendliness 77/100
seanmonstar/reqwest#3121 · 2 comments ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 68/100
ilya-zlobintsev/LACT#1235 ·
Maintainers usually reply within 1 day