[code-simplifier] Deduplicate exit-code explanation formatting in AzureDevOpsSummaryReporter

Closed

#11,979 opened on Oct 16, 2026 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty: 2/5
Estimated time: 1-3 hours
Newbie friendliness: 25/100

Issue type: Refactor
Clarity: Mostly clear
Activity status: Active
Tech stack: csharp
Domain: ci-cd

Research direction

The duplicated exit-code segment sits in AppendModuleDiagnostics and AppendStatusStrip in src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/AzureDevOpsSummaryReporter.Markdown.cs, and the issue proposes a shared AppendExitCodeExplanation helper. A patch already exists on the branch copilot/simplify-azdo-exit-code-formatting-6abedbdc5994b9cf, so review that branch rather than starting fresh. Done means the rendered Markdown is byte-identical and AzureDevOpsSummaryReporterTests in Microsoft.Testing.Extensions.UnitTests still pass.

Written by the indexing model from the issue text.

Description

agentic-workflows type/automation type/tech-debt

[!TIP]
Your pull request is ready to create! 🎉 ✅

Everything is OK—the changes have been pushed to branch copilot/simplify-azdo-exit-code-formatting-6abedbdc5994b9cf. Please review the changes, including any protected files, before creating the pull request.

Create the pull request

The original pull request description is below.

Code Simplification - 2026-10-16

This PR simplifies code recently added in #11970 (Improve Azure DevOps summary reports with exit code explanations) to reduce duplication while preserving all functionality.

Files Simplified

src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/AzureDevOpsSummaryReporter.Markdown.cs - Extracted a private AppendExitCodeExplanation helper that renders the "Name — Reason" segment, which was duplicated verbatim between AppendModuleDiagnostics and AppendStatusStrip.

Improvements Made

Reduced Duplication
- Both methods previously repeated the identical three-call chain (CiRunSummaryExitCode.GetName(...), " — ", CiRunSummaryExitCode.GetReason(..., AzureDevOpsResources.ResourceManager)). This is now a single shared private method.
Enhanced Clarity
- Each call site now reads as "append the surrounding markup, then append the exit-code explanation", making the structure of the rendered string easier to follow.

Changes Based On

Recent changes from:

#11970 - [WIP] Improve Azure DevOps summary reports with exit code explanations

Testing

✅ dotnet build of Microsoft.Testing.Extensions.AzureDevOpsReport (all target frameworks) succeeds with 0 warnings/errors
✅ Microsoft.Testing.Extensions.UnitTests → AzureDevOpsSummaryReporterTests (24 tests) all pass
✅ No functional changes - the rendered Markdown output is byte-for-byte identical (same string literals in the same order)

Review Focus

Please verify:

The extracted helper preserves identical output ordering and punctuation
No other duplicate instances of this pattern were missed

[!NOTE]
GitHub Actions is not permitted to create or approve pull requests in this repository.

The changes have been pushed to branch copilot/simplify-azdo-exit-code-formatting-6abedbdc5994b9cf and are ready to review.

To fix the permissions issue, go to Settings → Actions → General and enable Allow GitHub Actions to create and approve pull requests. See also: gh-aw FAQ

Show patch preview (32 of 56 lines)

From e42cbf728142b7b748ca3642bd2b0cb71c83e752 Mon Sep 17 00:00:00 2001
X-GH-AW-Base-Commit: 88788a9eb5b067b3b96e3c5ad16511231a2fb463
From: "github-actions[bot]" <github-actions[bot]@users.noreply.github.com>
Date: Fri, 16 Oct 2026 13:28:53 +0000
Subject: [PATCH] Extract AppendExitCodeExplanation helper to deduplicate
 exit-code formatting

Co-authored-by: Copilot <[email protected]>
---
 .../AzureDevOpsSummaryReporter.Markdown.cs      | 17 +++++++++++------
 1 file changed, 11 insertions(+), 6 deletions(-)

diff --git a/src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/AzureDevOpsSummaryReporter.Markdown.cs b/src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/AzureDevOpsSummaryReporter.Markdown.cs
index 2636d7c..a340b32 100644
--- a/src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/AzureDevOpsSummaryReporter.Markdown.cs
+++ b/src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/AzureDevOpsSummaryReporter.Markdown.cs
@@ -189,9 +189,9 @@ private static int AppendModuleDiagnostics(
         string heading = new('#', headingLevel);
         if (includeExitCode && module.ExitCode != 0)
         {
-            builder.Append("> Module exit code: `").Append(module.ExitCode.ToString(CultureInfo.InvariantCulture)).Append("` (")
-                .Append(CiRunSummaryExitCode.GetName(module.ExitCode)).Append(" — ")
-                .Append(CiRunSummaryExitCode.GetReason(module.ExitCode, AzureDevOpsResources.ResourceManager)).Append(")\n\n");
+            builder.Append("> Module exit code: `").Append(module.ExitCode.ToString(CultureInfo.InvariantCulture)).Append("` (");
+            AppendExitCodeExplanation(builder, module.ExitCode);
+            builder.Append(")\n\n");
         }
 
         if (module.TopFailingClasses.Length > 0)
@@ -428,14 +428,19 @@ private static void AppendStatusStrip(
         builder.Append(" · ⏱ **").Append(duration is { } value ? FormatDuration(value) : "Unavailable").Append("**");
       
... (truncated)

[!WARNING]
Firewall blocked 88 domains

The following domains were blocked by the firewall during workflow execution:

0t3vsblobprodcus362.vsblob.vsassets.io

11vvsblobprodcus336.vsblob.vsassets.io

1javsblobprodcus364.vsblob.vsassets.io

1k9vsblobprodcus379.vsblob.vsassets.io

1oavsblobprodcus350.vsblob.vsassets.io

1p7vsblobprodcus324.vsblob.vsassets.io

1s1vsblobprodcus386.vsblob.vsassets.io

37bvsblobprodcus311.vsblob.vsassets.io

37cvsblobprodcus359.vsblob.vsassets.io

4m6vsblobprodcus384.vsblob.vsassets.io

4myvsblobprodcus32.vsblob.vsassets.io

4vyvsblobprodcus361.vsblob.vsassets.io

4zjvsblobprodcus390.vsblob.vsassets.io

51yvsblobprodcus36.vsblob.vsassets.io

5dkvsblobprodcus355.vsblob.vsassets.io

5rqvsblobprodcus385.vsblob.vsassets.io

6s7vsblobprodcus313.vsblob.vsassets.io

7k6vsblobprodcus337.vsblob.vsassets.io

7tjvsblobprodcus341.vsblob.vsassets.io

80zvsblobprodcus35.vsblob.vsassets.io

8xbvsblobprodcus382.vsblob.vsassets.io

96bvsblobprodcus338.vsblob.vsassets.io

ajhvsblobprodcus363.vsblob.vsassets.io

bcnvsblobprodcus378.vsblob.vsassets.io

builds.dotnet.microsoft.com

c78vsblobprodcus322.vsblob.vsassets.io

cflvsblobprodcus383.vsblob.vsassets.io

ci.dot.net

ckzvsblobprodcus347.vsblob.vsassets.io

d0svsblobprodcus381.vsblob.vsassets.io

data.nuget.org

dlbvsblobprodcus316.vsblob.vsassets.io

e7bvsblobprodcus348.vsblob.vsassets.io

fdpvsblobprodcus345.vsblob.vsassets.io

frdvsblobprodcus327.vsblob.vsassets.io

gbsvsblobprodcus365.vsblob.vsassets.io

gervsblobprodcus329.vsblob.vsassets.io

h6tvsblobprodcus346.vsblob.vsassets.io

i1qvsblobprodcus353.vsblob.vsassets.io

imzvsblobprodcus368.vsblob.vsassets.io

jd4vsblobprodcus366.vsblob.vsassets.io

josvsblobprodcus372.vsblob.vsassets.io

jrqvsblobprodcus343.vsblob.vsassets.io

k0ivsblobprodcus356.vsblob.vsassets.io

k4kvsblobprodcus344.vsblob.vsassets.io

kgfvsblobprodcus314.vsblob.vsassets.io

kh4vsblobprodcus325.vsblob.vsassets.io

kijvsblobprodcus387.vsblob.vsassets.io

kmuvsblobprodcus389.vsblob.vsassets.io

kxqvsblobprodcus376.vsblob.vsassets.io

l49vsblobprodcus358.vsblob.vsassets.io

l7avsblobprodcus319.vsblob.vsassets.io

ljcvsblobprodcus317.vsblob.vsassets.io

lylvsblobprodcus31.vsblob.vsassets.io

m16vsblobprodcus374.vsblob.vsassets.io

m6xvsblobprodcus342.vsblob.vsassets.io

m8dvsblobprodcus37.vsblob.vsassets.io

mfjvsblobprodcus373.vsblob.vsassets.io

n3kvsblobprodcus335.vsblob.vsassets.io

nn8vsblobprodcus340.vsblob.vsassets.io

o3svsblobprodcus318.vsblob.vsassets.io

ofvvsblobprodcus315.vsblob.vsassets.io

p2ovsblobprodcus312.vsblob.vsassets.io

pc2vsblobprodcus360.vsblob.vsassets.io

pdfvsblobprodcus380.vsblob.vsassets.io

pe3vsblobprodcus354.vsblob.vsassets.io

pe4vsblobprodcus351.vsblob.vsassets.io

pkgs.dev.azure.com

pkvvsblobprodcus321.vsblob.vsassets.io

rcxvsblobprodcus328.vsblob.vsassets.io

s4uvsblobprodcus326.vsblob.vsassets.io

s8mvsblobprodcus38.vsblob.vsassets.io

se1vsblobprodcus349.vsblob.vsassets.io

sqdvsblobprodcus333.vsblob.vsassets.io

st8vsblobprodcus339.vsblob.vsassets.io

tphvsblobprodcus375.vsblob.vsassets.io

u3hvsblobprodcus371.vsblob.vsassets.io

u6ovsblobprodcus377.vsblob.vsassets.io

ukkvsblobprodcus352.vsblob.vsassets.io

uy6vsblobprodcus34.vsblob.vsassets.io

v53vsblobprodcus320.vsblob.vsassets.io

vb4vsblobprodcus33.vsblob.vsassets.io

vwvvsblobprodcus334.vsblob.vsassets.io

x3yvsblobprodcus370.vsblob.vsassets.io

xupvsblobprodcus332.vsblob.vsassets.io

yluvsblobprodcus367.vsblob.vsassets.io

yttvsblobprodcus357.vsblob.vsassets.io

ytvvsblobprodcus310.vsblob.vsassets.io

To allow these domains, add them to the network.allowed list in your workflow frontmatter:
network:
  allowed:
    - defaults
    - "0t3vsblobprodcus362.vsblob.vsassets.io"
    - "11vvsblobprodcus336.vsblob.vsassets.io"
    - "1javsblobprodcus364.vsblob.vsassets.io"
    - "1k9vsblobprodcus379.vsblob.vsassets.io"
    - "1oavsblobprodcus350.vsblob.vsassets.io"
    - "1p7vsblobprodcus324.vsblob.vsassets.io"
    - "1s1vsblobprodcus386.vsblob.vsassets.io"
    - "37bvsblobprodcus311.vsblob.vsassets.io"
    - "37cvsblobprodcus359.vsblob.vsassets.io"
    - "4m6vsblobprodcus384.vsblob.vsassets.io"
    - "4myvsblobprodcus32.vsblob.vsassets.io"
    - "4vyvsblobprodcus361.vsblob.vsassets.io"
    - "4zjvsblobprodcus390.vsblob.vsassets.io"
    - "51yvsblobprodcus36.vsblob.vsassets.io"
    - "5dkvsblobprodcus355.vsblob.vsassets.io"
    - "5rqvsblobprodcus385.vsblob.vsassets.io"
    - "6s7vsblobprodcus313.vsblob.vsassets.io"
    - "7k6vsblobprodcus337.vsblob.vsassets.io"
    - "7tjvsblobprodcus341.vsblob.vsassets.io"
    - "80zvsblobprodcus35.vsblob.vsassets.io"
    - "8xbvsblobprodcus382.vsblob.vsassets.io"
    - "96bvsblobprodcus338.vsblob.vsassets.io"
    - "ajhvsblobprodcus363.vsblob.vsassets.io"
    - "bcnvsblobprodcus378.vsblob.vsassets.io"
    - "builds.dotnet.microsoft.com"
    - "c78vsblobprodcus322.vsblob.vsassets.io"
    - "cflvsblobprodcus383.vsblob.vsassets.io"
    - "ci.dot.net"
    - "ckzvsblobprodcus347.vsblob.vsassets.io"
    - "d0svsblobprodcus381.vsblob.vsassets.io"
    - "data.nuget.org"
    - "dlbvsblobprodcus316.vsblob.vsassets.io"
    - "e7bvsblobprodcus348.vsblob.vsassets.io"
    - "fdpvsblobprodcus345.vsblob.vsassets.io"
    - "frdvsblobprodcus327.vsblob.vsassets.io"
    - "gbsvsblobprodcus365.vsblob.vsassets.io"
    - "gervsblobprodcus329.vsblob.vsassets.io"
    - "h6tvsblobprodcus346.vsblob.vsassets.io"
    - "i1qvsblobprodcus353.vsblob.vsassets.io"
    - "imzvsblobprodcus368.vsblob.vsassets.io"
    - "jd4vsblobprodcus366.vsblob.vsassets.io"
    - "josvsblobprodcus372.vsblob.vsassets.io"
    - "jrqvsblobprodcus343.vsblob.vsassets.io"
    - "k0ivsblobprodcus356.vsblob.vsassets.io"
    - "k4kvsblobprodcus344.vsblob.vsassets.io"
    - "kgfvsblobprodcus314.vsblob.vsassets.io"
    - "kh4vsblobprodcus325.vsblob.vsassets.io"
    - "kijvsblobprodcus387.vsblob.vsassets.io"
    - "kmuvsblobprodcus389.vsblob.vsassets.io"
    - "kxqvsblobprodcus376.vsblob.vsassets.io"
    - "l49vsblobprodcus358.vsblob.vsassets.io"
    - "l7avsblobprodcus319.vsblob.vsassets.io"
    - "ljcvsblobprodcus317.vsblob.vsassets.io"
    - "lylvsblobprodcus31.vsblob.vsassets.io"
    - "m16vsblobprodcus374.vsblob.vsassets.io"
    - "m6xvsblobprodcus342.vsblob.vsassets.io"
    - "m8dvsblobprodcus37.vsblob.vsassets.io"
    - "mfjvsblobprodcus373.vsblob.vsassets.io"
    - "n3kvsblobprodcus335.vsblob.vsassets.io"
    - "nn8vsblobprodcus340.vsblob.vsassets.io"
    - "o3svsblobprodcus318.vsblob.vsassets.io"
    - "ofvvsblobprodcus315.vsblob.vsassets.io"
    - "p2ovsblobprodcus312.vsblob.vsassets.io"
    - "pc2vsblobprodcus360.vsblob.vsassets.io"
    - "pdfvsblobprodcus380.vsblob.vsassets.io"
    - "pe3vsblobprodcus354.vsblob.vsassets.io"
    - "pe4vsblobprodcus351.vsblob.vsassets.io"
    - "pkgs.dev.azure.com"
    - "pkvvsblobprodcus321.vsblob.vsassets.io"
    - "rcxvsblobprodcus328.vsblob.vsassets.io"
    - "s4uvsblobprodcus326.vsblob.vsassets.io"
    - "s8mvsblobprodcus38.vsblob.vsassets.io"
    - "se1vsblobprodcus349.vsblob.vsassets.io"
    - "sqdvsblobprodcus333.vsblob.vsassets.io"
    - "st8vsblobprodcus339.vsblob.vsassets.io"
    - "tphvsblobprodcus375.vsblob.vsassets.io"
    - "u3hvsblobprodcus371.vsblob.vsassets.io"
    - "u6ovsblobprodcus377.vsblob.vsassets.io"
    - "ukkvsblobprodcus352.vsblob.vsassets.io"
    - "uy6vsblobprodcus34.vsblob.vsassets.io"
    - "v53vsblobprodcus320.vsblob.vsassets.io"
    - "vb4vsblobprodcus33.vsblob.vsassets.io"
    - "vwvvsblobprodcus334.vsblob.vsassets.io"
    - "x3yvsblobprodcus370.vsblob.vsassets.io"
    - "xupvsblobprodcus332.vsblob.vsassets.io"
    - "yluvsblobprodcus367.vsblob.vsassets.io"
    - "yttvsblobprodcus357.vsblob.vsassets.io"
    - "ytvvsblobprodcus310.vsblob.vsassets.io"
See Network Configuration for more information.

🤖 Automated content by GitHub Copilot. Generated by the Code Simplifier workflow. · copilot · auto · 108.4 AIC · ⌖ 14.8 AIC · ⊞ 14.8K · [◷]( · ◷)

_{Add this agentic workflow to your repo}

To install this agentic workflow, run

gh aw add githubnext/agentics/workflows/code-simplifier.md@main

expires on Oct 17, 2026, 1:31 PM UTC

Dominant language: C#
Stars: 1.1k
Forks: 312
Avg merge: 9h 13m
Merged PRs (30d): 411

Getting set up

No Dockerfile or Docker Compose file
Has a pull request template
Read the contributing guide

First steps

Read the whole issue, then the project's contributing guide.
Comment on the issue to say you are picking it up — it saves two people doing the same work.
Fork the repository and make your change on a branch.
Open a pull request that references the issue number.

More from microsoft/testfx

[efficiency-improver] Memoize CI summary module-identity duplicate detection
Open
- Is something wrong?
agentic-workflows area/performance type/automation

Difficulty 4/5 3-5 days Newbie friendliness 15/100

microsoft/testfx#12009 · Opened Oct 18, 2026

Maintainers usually reply within 1 day
[duplicate-code] Duplicate `HasDuplicateModuleIdentity` logic between AzureDevOps and GitHub Actions reporters
Possibly taken @Evangelink claimed this today. Open
- Is something wrong?
type/automation type/tech-debt

microsoft/testfx#12000 · 1 reaction · 2 assignees · Opened Oct 18, 2026

Maintainers usually reply within 1 day
[test-improver] Add unit tests for DotnetTestConnection.StartServerControlChannelAsync guard conditions
Possibly taken @Evangelink claimed this today. Open
- Is something wrong?
area/mtp needs/triage

microsoft/testfx#11998 · 1 reaction · 2 assignees · Opened Oct 17, 2026

Maintainers usually reply within 1 day
`--report-gh` annotations, groups and notices are dropped under `dotnet test`; only the job summary survives
Open
- Is something wrong?
area/mtp-github-actions-report external/dotnet-test needs/triage

Difficulty 4/5 3-5 days Newbie friendliness 56/100

microsoft/testfx#11996 · Opened Oct 17, 2026

Maintainers usually reply within 1 day
Allow a trailing CancellationToken parameter on MSTest test methods
Possibly taken @Evangelink claimed this 2 days ago. Open
- Is something wrong?
area/mstest area/parameterized-tests needs/triage

Difficulty 4/5 3-5 days Newbie friendliness 22/100

microsoft/testfx#11986 · Opened Oct 16, 2026

Maintainers usually reply within 1 day

All issues in microsoft/testfx

Similar issues

[P2] Compiler: absent Promise instance properties read as null instead of undefined
Open
- Is something wrong?
bug priority: P2

Difficulty 2/5 1-3 hours Newbie friendliness 78/100

nickna/SharpTS#2704 · Opened Oct 19, 2026

Maintainers usually reply within 1 day
Parameterless constructor is not a must-provided by user when a struct has a field initializer
Open
- Is something wrong?
:watch: Not Triaged dotnet-csharp/svc fundamentals/subsvc

Difficulty 1/5 Under an hour Newbie friendliness 88/100

dotnet/docs#56424 · Opened Oct 18, 2026

Maintainers usually reply within 1 day
Wrong values of Kernel32.FileShare.Delete and Kernel32.FileAttributes.PosixSemantics
Possibly taken @ElectLive claimed this today. Open
- Is something wrong?
bug good first issue help wanted

Difficulty 1/5 Under an hour Newbie friendliness 83/100

ForNeVeR/TruePath#241 · 1 comment · Opened Oct 18, 2026

Maintainers usually reply within 1 day
Bug: Arrow-key navigation in Details layout doesn't start at the top after opening a folder
Open
- Is something wrong?
Difficulty 2/5 1-3 hours Newbie friendliness 66/100

files-community/Files#19047 · Opened Oct 18, 2026

Maintainers usually reply within 1 day
Fragment tlshello breaks REALITY on Xray core (v2rayNG uses 1-3)
Open
- Is something wrong?
bug

Difficulty 2/5 1-3 hours Newbie friendliness 78/100

2dust/v2rayN#10407 · Opened Oct 18, 2026

Maintainers usually reply within 1 day

More C# issues

[code-simplifier] Deduplicate exit-code explanation formatting in AzureDevOpsSummaryReporter

Is something wrong?

Assessment

Research direction

Description

Code Simplification - 2026-10-16

Files Simplified

Improvements Made

Changes Based On

Testing

Review Focus

Getting set up

First steps

More from microsoft/testfx

Is something wrong?

Is something wrong?

Is something wrong?

Is something wrong?

Is something wrong?

Similar issues

Is something wrong?

Is something wrong?

Is something wrong?

Is something wrong?

Is something wrong?

Get new issues in your inbox