M-NO-GLOB-REEXPORTS is excessively broad
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 25/100
- Issue type
- Documentation
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- rust
- Domain
- documentation
Research direction
No file, test, or entry point is named. Start by locating the repository guidance for M-NO-GLOB-REEXPORTS, then determine how its wording should distinguish structural re-exports from duplicate public paths; done means the guideline reflects the agreed scope and its review expectations.
Written by the indexing model from the issue text.
Description
It is perfectly fine to re-export types within a crate for filesystem-structural reasons, if we want to split some types off to a separate file. Glob re-exports should only be discouraged for cases where the re-exported item is already public via a different path (e.g. part of a different crate or via another public module).
For filesystem-structural reasons, no review of what is being re-exported is expected, either - each file should have clear pub or lack thereof on its types, indicating what is part of the public API. As an alternative UX, generated documentation can be used for review.
- Dominant language
- Rust
- Stars
- 206
- Forks
- 25
- Avg merge
- 6d 13h
- Merged PRs (30d)
- 3
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from microsoft/rust-guidelines
-
Remove "*.png"Openissue
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
microsoft/rust-guidelines#52 · 1 comment ·
-
request
Difficulty 4/5 3-5 days Newbie friendliness 35/100
microsoft/rust-guidelines#63 ·
-
easy-pr request
Difficulty 4/5 3-5 days Newbie friendliness 35/100
microsoft/rust-guidelines#60 ·
-
issue
Difficulty 5/5 Over a week Newbie friendliness 30/100
microsoft/rust-guidelines#56 ·
-
easy-pr request
Difficulty 2/5 1-3 hours Newbie friendliness 25/100
microsoft/rust-guidelines#51 ·
All issues in microsoft/rust-guidelines
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
joshstevens19/rindexer#483 ·
Maintainers usually reply within 1 day
-
VX_PRINT_DROPS prints each drop point twice on the default code generator, the second time at line 0Open
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
CommunityToolkit/Aspire#2231 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100