[Bug] Chromium: launch({ proxy: { username, password } }) credentials are sent to a website's 401 Basic challenge
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 45/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- playwright, python, typescript
Research direction
Start with CRBrowserContext and CRNetworkManager._onAuthRequired in the Chromium backend, then trace authenticateProxyViaCredentials() and _shouldProvideCredentials(event.request.url); the issue says Firefox and WebKit may need the same check. Find or add coverage for a cached proxy authentication followed by a site's 401 Basic challenge. Done when proxy credentials answer proxy challenges only and are never sent to the site, while configured httpCredentials continue to follow their origin.
Written by the indexing model from the issue text.
Description
Version
- Playwright 1.62.0 (Python,
playwrightpackage; same code in playwright-corecoreBundle.js) - Chromium (bundled
chromium_headless_shell-1234) - macOS 26.5 (should be platform independent)
Steps to reproduce
Fully local, self-contained script (no external network access): a Basic-auth HTTP proxy on 127.0.0.1 and a site that returns 401 WWW-Authenticate: Basic.
"""Minimal repro: Playwright launch proxy credentials are sent to a site's 401 Basic challenge.
Local only: a tiny HTTP proxy that requires Basic auth (127.0.0.1) and a site that answers 401 Basic.
"""
import asyncio
import base64
import threading
from http.server import BaseHTTPRequestHandler, ThreadingHTTPServer
import urllib.request
from playwright.async_api import async_playwright
PROXY_USER, PROXY_PASS = "proxyuser", "proxy-secret-123"
SEEN = []
class Site(BaseHTTPRequestHandler):
def do_GET(self):
SEEN.append((self.path, self.headers.get("Authorization")))
if self.path.startswith("/protected"):
self.send_response(401)
self.send_header("WWW-Authenticate", 'Basic realm="site"')
self.end_headers()
self.wfile.write(b"no")
return
self.send_response(200)
self.end_headers()
self.wfile.write(b"ok")
def log_message(self, *a):
pass
class Proxy(BaseHTTPRequestHandler):
def do_GET(self):
want = "Basic " + base64.b64encode(f"{PROXY_USER}:{PROXY_PASS}".encode()).decode()
if self.headers.get("Proxy-Authorization") != want:
self.send_response(407)
self.send_header("Proxy-Authenticate", 'Basic realm="proxy"')
self.end_headers()
return
headers = {k: v for k, v in self.headers.items() if k.lower() not in ("proxy-authorization", "proxy-connection")}
req = urllib.request.Request(self.path.replace("site.test", "127.0.0.1"), headers=headers)
try:
resp = urllib.request.urlopen(req)
status, body, rh = resp.status, resp.read(), resp.headers
except urllib.error.HTTPError as e:
status, body, rh = e.code, e.read(), e.headers
self.send_response(status)
for k, v in rh.items():
if k.lower() not in ("transfer-encoding", "connection"):
self.send_header(k, v)
self.end_headers()
self.wfile.write(body)
def log_message(self, *a):
pass
def serve(handler):
srv = ThreadingHTTPServer(("127.0.0.1", 0), handler)
threading.Thread(target=srv.serve_forever, daemon=True).start()
return srv
async def main():
site, proxy = serve(Site), serve(Proxy)
site_url = f"http://site.test:{site.server_port}"
async with async_playwright() as p:
browser = await p.chromium.launch(
proxy={"server": f"http://127.0.0.1:{proxy.server_port}", "username": PROXY_USER, "password": PROXY_PASS},
args=["--proxy-bypass-list=<-loopback>"],
)
page = await browser.new_page()
r1 = await page.goto(site_url + "/warm") # proxy auth happens here (cache becomes warm)
r2 = await page.goto(site_url + "/protected") # site answers 401 Basic
print("warm status", r1.status, "| protected status", r2.status)
await browser.close()
leaked = [a for path, a in SEEN if path.startswith("/protected") and a]
for path, a in SEEN:
print("site saw", path, "Authorization:", (base64.b64decode(a.split()[1]).decode() if a else None))
print("LEAK" if any(PROXY_PASS in base64.b64decode(a.split()[1]).decode() for a in leaked) else "NO LEAK")
asyncio.run(main())
Run: pip install playwright && playwright install chromium && python repro.py
Expected
The proxy credentials are used only for the proxy's 407 Proxy-Authenticate challenge. A site's 401 WWW-Authenticate challenge should get no credentials (or only httpCredentials explicitly configured for that origin).
Actual
The site receives Authorization: Basic base64("proxyuser:proxy-secret-123"):
warm status 200 | protected status 401
site saw /warm Authorization: None
site saw /protected Authorization: None
site saw /protected Authorization: proxyuser:proxy-secret-123 <-- proxy credentials sent to the website
Cause (from reading the source)
CRBrowserContextconstructor callsauthenticateProxyViaCredentials(), which copies the launch proxy credentials intothis._options.httpCredentials = { username, password }with noorigin, overwriting any user-suppliedhttpCredentials.CRNetworkManager._onAuthRequired(event)decides via_shouldProvideCredentials(event.request.url). Without anorigin, that returns true for every request, so it answersFetch.authRequiredwithProvideCredentialsregardless ofevent.authChallenge.source("Proxy"vs"Server").
On a cold cache the single per-request attempt is consumed by the proxy's 407, so the site's 401 gets CancelAuth; once the proxy auth is cached, the site's 401 gets the proxy credentials.
Things tried
new_context(http_credentials={..., "origin": <proxy origin>})together with launch proxy credentials: overwritten by step 1, still leaks.- Proxy credentials only via
http_credentialswith proxy origin (no launch credentials): the origin is compared against the request URL (the site), so the proxy's 407 is not answered. extra_http_headers={"Proxy-Authorization": ...}: for HTTPS this ends up inside the tunnel and is sent to the site, which is worse.
Suggested fix
Keep proxy credentials separate from httpCredentials, and in _onAuthRequired use event.authChallenge.source: answer "Proxy" challenges only with the proxy credentials and "Server" challenges only with httpCredentials (subject to its origin). Firefox/WebKit backends may need the same check.
Security note
Any website the automated browser visits can obtain the proxy credentials by returning 401 Basic. For authenticated corporate/residential proxies this exposes the proxy account.
- Dominant language
- TypeScript
- Stars
- 97.4k
- Forks
- 6.6k
- Avg merge
- 23h 15m
- Merged PRs (30d)
- 260
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from microsoft/playwright
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
microsoft/playwright#43327 ·
Maintainers usually reply within 1 day
-
[Feature]: Set `this.name` in `TargetClosedError` constructorMay be free again @LeonxLJX claimed this 39 days ago, and no pull request is open. OpenP3-collecting-feedback
Difficulty 1/5 Under an hour Newbie friendliness 86/100
microsoft/playwright#42522 · 7 comments ·
Maintainers usually reply within 1 day
-
[Regression]: page.screenshot() and route.fulfill() do not recognize uppercase file extensionsPossibly taken @EDWARD-012 claimed this today. Open
Difficulty 1/5 Under an hour Newbie friendliness 30/100
microsoft/playwright#43323 ·
Maintainers usually reply within 1 day
-
[Regression]: AI aria snapshot drops a button's name when its icon wrapper has whitespace or a CSS-sized SVGPossibly taken @pavelfeldman claimed this today. Open
Difficulty 4/5 1-2 days Newbie friendliness 25/100
microsoft/playwright#43315 ·
Maintainers usually reply within 1 day
-
[Bug]: Trace viewer pads narrow (phone-sized) snapshots with a checkerboard stripPossibly taken @pavelfeldman claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 35/100
microsoft/playwright#43313 ·
Maintainers usually reply within 1 day
All issues in microsoft/playwright
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 83/100
Zettlr/Zettlr#6610 · 1 comment ·
Maintainers usually reply within 1 day
-
Feil lovtekst i bekreftelsen når leder melder unntak fra oppfølgingsplanPossibly taken @AudunSorheim claimed this today. Open
Difficulty 1/5 Under an hour Newbie friendliness 92/100
navikt/syfo-oppfolgingsplan-frontend#1110 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
db-ux-design-system/core-web#8461 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
Cannot run an integration on windows when power shell is selected as the default profile terminalOpenPriority/Blocker Type/Bug
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
wso2/product-integrator#2767 ·
Maintainers usually reply within 1 day