`build.bat` leaves binaries it no longer builds in `sdk\node\bin`
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 72/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- nodejs, shell
- Domain
- build-system
Research direction
Start in build.bat, where binaries are copied into sdk\node\bin\<arch> and the cleanup removes only named files such as plm.exe. Make the cleanup remove any binary in that folder the build no longer produces. Then run node --test dist/package.test.js in sdk/node/tests/integration, which checks the folder against the expected lists in test-helpers.ts. Done when a clean build leaves no stale .exe or .dll there and the test passes.
Written by the indexing model from the issue text.
Description
Relevant area(s)
Windows
Brief description of your issue
build.bat copies the binaries it builds into sdk\node\bin\<arch>, and removes only binaries it names there: plm.exe, and the WSLc daemon and wslcsdk.dll in a build without WSLc. Any other binary the build stops producing stays, and npm pack includes it. wxc-host-prep.exe and winhttp-proxy-shim.exe, no longer built since #1558, remain in any clone that built them before.
Steps to reproduce
- Run
build.batat5c2735db, the commit before #1558, then atmain. - In
sdk/node/tests/integration, runnode --test dist/package.test.js.
Expected behavior
sdk\node\bin\<arch> holds no binary the build no longer produces, and the test passes.
Actual behavior
plm.exe is removed, but wxc-host-prep.exe and winhttp-proxy-shim.exe remain in sdk\node\bin\x64, npm pack --dry-run lists both, and the test fails:
AssertionError [ERR_ASSERTION]: Unexpected binaries in ...\node_modules\@microsoft\mxc-sdk\bin\x64 — add them to the expected lists in test-helpers.ts: winhttp-proxy-shim.exe, wxc-host-prep.exe
- Dominant language
- Rust
- Stars
- 3.1k
- Forks
- 171
- Avg merge
- 2d 6h
- Merged PRs (30d)
- 106
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from microsoft/mxc
-
Backend-Seatbelt Issue-Docs
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
Area-Node-SDK Issue-Task
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
Maintainers usually reply within 1 day
-
Embedded NUL in containerId can result in duplicate identitiesPossibly taken @safmswork claimed this 12 days ago. OpenBackend-ProcessContainer Issue-Bug OS-Linux OS-Windows
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
microsoft/mxc#1621 · 1 comment ·
Maintainers usually reply within 1 day
-
Issue-Docs
Difficulty 1/5 1-3 hours Newbie friendliness 88/100
microsoft/mxc#1515 · 1 comment ·
Maintainers usually reply within 1 day
-
Area-Build Issue-Bug Needs-Attention OS-MacOS OS-Windows
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day
Similar issues
-
docs(metrics): replace stale src/metrics.rs line anchors in dashboard-metrics.md with symbol namesOpen
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Maintainers usually reply within 1 day
-
ci-cd desktop size:low telemetry-improvement telemetry-round-1
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
vfarcic/dot-agent-deck#2079 ·
Maintainers usually reply within 1 day
-
修改文件名时主键盘上的数字无法输入Openbug
Difficulty 2/5 1-3 hours Newbie friendliness 63/100
qingjian-team/qingjian#894 ·
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
rubys/roundhouse#1757 ·
-
enhancement user-priority/P3
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day