missing errno assigns

Open
#1,135 3 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
42/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
c

Research direction

Start by reviewing the Chimera Linux mimalloc-errno.patch linked in the issue and locating the corresponding allocation-failure paths in mimalloc. Verify which failures return NULL without setting ENOMEM, then add or update focused coverage so the relevant malloc API behavior is confirmed.

Written by the indexing model from the issue text.

Description

chimera linux has a patch for some missing errno assigns: https://github.com/chimera-linux/cports/blob/187f77f7f29304f886648522d36f66a1a3514409/main/musl/patches/mimalloc-errno.patch

that was needed to fix cases of e.g. allocating some huge amount of memory (like 1tb when host has 16gb) where the allocation fails, and a null pointer is returned, but the corresponding errno is not set to enomem so the application doesn't handle it since it expects it to be set (per the malloc api). perhaps this fix should be applied here too?

Dominant language
C
Stars
13.6k
Forks
1.2k
Avg merge
18h 12m
Merged PRs (30d)
20

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from microsoft/mimalloc

All issues in microsoft/mimalloc

Similar issues

More C issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.