Disable DeleteCollection for DCP resources
Maintainers usually reply within 1 day
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 68/100
Research direction
Start by reading Tilt filepath storage's DeleteCollection implementation and the v2NamespaceLifecycleStorage.DeleteCollection delegation described in the issue. Review the API storage tests, add coverage that collection deletion returns MethodNotSupported for the applicable V1 and V2 resources, and confirm shutdown and namespace cleanup still use individual Delete requests.
Written by the indexing model from the issue text.
Description
Tilt filepath storage implements DeleteCollection by directly removing matching files. It does not run the per-object deletion path, honor finalizers, or publish deletion watch events.
DCP production cleanup does not require collection deletion: shutdown cleanup and V2 namespace cleanup list resources and issue individual Delete requests. However, DCP currently exposes DeleteCollection through its API, including explicitly delegating it for namespace-scoped V2 child resources in v2NamespaceLifecycleStorage.DeleteCollection.
Restrict collection deletion so clients cannot bypass normal controller-driven cleanup semantics.
Scope
- Reject
DeleteCollectionfor namespace-scoped V2 resources. - Review V1 resources for the same exposure and disable the operation where it is not intentionally supported.
- Update API storage tests to verify collection deletion returns
MethodNotSupported. - Confirm ordinary shutdown and namespace cleanup continue using individual object deletion.
- Dominant language
- Go
- Stars
- 191
- Forks
- 26
- Avg merge
- 22h 49m
- Merged PRs (30d)
- 23
Getting set up
Starts the project's dev container in your browser, under your own GitHub account.
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from microsoft/dcp
-
Add application iconOpen
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
Difficulty 5/5 Over a week Newbie friendliness 35/100
Maintainers usually reply within 1 day
-
API server: creating an Executable hangs 30-45 s (504) while the log storage restarts its parent resource watcher for ExecutablesPossibly taken A pull request linked to this issue is open or already merged. Open
Difficulty 4/5 3-5 days Newbie friendliness 45/100
microsoft/dcp#286 · 6 comments · 1 assignee ·
Maintainers usually reply within 1 day
-
Difficulty 5/5 Over a week Newbie friendliness 30/100
microsoft/dcp#206 · 2 comments · 1 reaction ·
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 48/100
Maintainers usually reply within 1 day
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
SocialGouv/iterion#2369 ·
Maintainers usually reply within 1 day
-
area/ci bug priority/p3
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
documentation help wanted needs-triage
Difficulty 1/5 1-3 hours Newbie friendliness 75/100
hivecommons/hive#11606 · 2 comments ·
Maintainers usually reply within 1 day
-
documentation
Difficulty 1/5 Under an hour Newbie friendliness 85/100
gravitational/teleport#69869 ·
-
category:agent
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
LanternOps/breeze#8493 ·
Maintainers usually reply within 1 day