Azure Data Factory Activity Iterator Bug
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 35/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- azure, python
- Domain
- backend, testing-qa
Research direction
Start by placing pl_package_import.json in pipeline and test_package_import.py in tests, then run the supplied test to reproduce NoRemainingPipelineActivitiesMeetDependencyConditionsError. Inspect activity iteration and dependency evaluation around the Until loop, including the success and failure branches; done means the test completes and activities run in the expected order across iterations.
Written by the indexing model from the issue text.
Description
The activity iterator does not handle events in the same order that I would expect it to.
In the following scenario:
With activities within the Until loop as below:
The behaviour is not as would be expected. It appears that the addition of the failure condition to refresh the token causes the final activities (within the next If conditional) to not be evaluated. In addition, on the second iteration of the loop, the activities are evaluated out of sequence.
pl_package_import.json
test_package_import.py
Attached above are the files, to run successfully these would need to be added to a directory pipeline for pl_package_import.json and tests for test_package_import.py.
In this particular test, it is expected that it goes into the loop, then it processes the next activity in sequence. As it is incomplete, the condition should assess that it goes onto the next iteration of the Until loop. However, it raises exception NoRemainingPipelineActivitiesMeetDependencyConditionsError.
Removing lines 113 to 278 of the pipeline file fixes this, see the file below. This suggests that there is a bug where activities have a success and failure branch in terms of evaluating the next activities.
pl_package_import.json
I also note that the activities in the next iterations are evaluated out of order. For the second pl_package_import.json (i.e. the one that passes the test) where it compares if it goes into the if statement and runs a pipeline in the event of the conditional being false, the next activity should be a Wait activity, being the first one in the loop, but in reality it is the Web Activity, the second activity in the loop.
- Dominant language
- Python
- Stars
- 135
- Forks
- 43
- Avg merge
- 1h 14m
- Merged PRs (30d)
- 1
Getting set up
Starts the project's dev container in your browser, under your own GitHub account.
- No Dockerfile or Docker Compose file
- No pull request template
- No contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from microsoft/data-factory-testing-framework
-
A new ExpressionRuntime (Lark grammar compile) per evaluated expression makes evaluation ~5x slowerOpen
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
IfCondition evaluates the expressions of the branch not taken (case-sensitive "activities" check)Open
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
-
DataFactoryTestingFrameworkExpressionsEvaluator adds status property even if None is set.Possibly taken @LeonardHd claimed this 433 days ago. Openbug
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
All issues in microsoft/data-factory-testing-framework
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 Half a day Newbie friendliness 70/100
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Qiskit/qiskit-ibm-runtime#3431 · 1 comment ·
Maintainers usually reply within 1 day
-
[Lesson] A compatibility-gate rejection is a verdict, not something to overwrite with --accept-riskOpenlesson-submission needs-ac pending-review
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
Ikalus1988/MisakaNet#2870 ·
Maintainers usually reply within 1 day
-
feature:LinkChecker
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
digitalfabrik/integreat-cms#4594 ·
Maintainers usually reply within 5 days