RootAccessFilter doesn't work for the Docker image packaged by AML
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Newbie friendliness
- 70/100
Research direction
Start from the RootAccessFilter class, which currently matches the exact string "GET / HTTP/1.1" in the access log message. Find where that match is applied and check whether the same logic also covers HTTP/1.0. Done when root-path health-check lines from the Nginx proxy (HTTP/1.0) are filtered out as well as the HTTP/1.1 ones, which you can confirm with a test that feeds both log lines through the filter.
Written by the indexing model from the issue text.
Description
RootAccessFilter checks "GET / HTTP/1.1" in the response message while in the docker image packaged by AML there is an Nginx reverse proxy in front of the inference server, and the proxy HTTP version is 1.0 by default.
The filter doesn't work for this and fails to remove the health check from the access log.
Could we update RootAccessFilter to check "GET / HTTP/1.0" as well?
Thanks!
- Dominant language
- Python
- Stars
- 28
- Forks
- 10
- Avg merge
- 7h 58m
- Merged PRs (30d)
- 10
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from microsoft/azureml-inference-server
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
microsoft/azureml-inference-server#133 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 45/100
microsoft/azureml-inference-server#116 ·
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 18/100
microsoft/azureml-inference-server#112 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
microsoft/azureml-inference-server#111 · 1 reaction ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 1-3 hours Newbie friendliness 55/100
microsoft/azureml-inference-server#104 ·
Maintainers usually reply within 1 day
All issues in microsoft/azureml-inference-server
Similar issues
-
Layout accepts a step threshold of 0 or less, then in-toto-verify crashes with StopIterationPossibly taken @BahaaMattar claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
Maintainers usually reply within 1 day
-
needs discussion
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
openfga/openfga.dev#1436 · 1 comment ·
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
usb-device-hid: MouseInterface reports bInterfaceProtocol 1 (keyboard) instead of 2Possibly taken @Duhan07 claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
micropython/micropython-lib#1176 ·