RootAccessFilter doesn't work for the Docker image packaged by AML

Open Beginner friendly
#77 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
70/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
docker, nginx, python
Domain
backend

Research direction

Start from the RootAccessFilter class, which currently matches the exact string "GET / HTTP/1.1" in the access log message. Find where that match is applied and check whether the same logic also covers HTTP/1.0. Done when root-path health-check lines from the Nginx proxy (HTTP/1.0) are filtered out as well as the HTTP/1.1 ones, which you can confirm with a test that feeds both log lines through the filter.

Written by the indexing model from the issue text.

Description

RootAccessFilter checks "GET / HTTP/1.1" in the response message while in the docker image packaged by AML there is an Nginx reverse proxy in front of the inference server, and the proxy HTTP version is 1.0 by default.

The filter doesn't work for this and fails to remove the health check from the access log.

Could we update RootAccessFilter to check "GET / HTTP/1.0" as well?

Thanks!

Dominant language
Python
Stars
28
Forks
10
Avg merge
7h 58m
Merged PRs (30d)
10

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from microsoft/azureml-inference-server

All issues in microsoft/azureml-inference-server

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.