NullReferenceException in >GraphViewer.CreateRectToFillCanvas() when re-assigning the graph
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 30/100
Research direction
Start with AutomaticGraphLayoutControl.SetGraph() and follow the re-assignment path into GraphViewer.CreateRectToFillCanvas(). Reproduce assigning a graph, assigning null, and assigning the same graph again; done means the sequence no longer throws a NullReferenceException.
Written by the indexing model from the issue text.
Description
hi, when using the AutomaticGraphLayoutControl, assigning a graph, then assigning null and then assigning the same graph (I didn't test with a different graph...), a NRE is thrown because the Parent of the GraphCanvas was null.
this is fixed by changing the way AutomaticGraphLayoutControl.SetGraph() handles the re-assignment case... just some if statements need to be changed.
i have a fix in my fork. should i PR it?
- Dominant language
- C#
- Stars
- 1.5k
- Forks
- 319
- PR merge metrics
- No merged PRs in 30d
Getting set up
We have not checked this project's setup files yet. Start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from microsoft/automatic-graph-layout
-
Difficulty 3/5 1-2 days Newbie friendliness 64/100
microsoft/automatic-graph-layout#395 · 1 comment ·
-
Difficulty 3/5 1-2 days Newbie friendliness 55/100
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
-
Issue with framework reference in the GraphViewerGDI.nuspecMay be free again @levnach claimed this 257 days ago, and no pull request is open. Open
microsoft/automatic-graph-layout#390 · 6 comments · 2 reactions · 2 assignees ·
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
microsoft/automatic-graph-layout#389 · 1 comment · 1 reaction ·
All issues in microsoft/automatic-graph-layout
Similar issues
-
copilot documentation
Difficulty 1/5 Under an hour Newbie friendliness 88/100
Maintainers usually reply within 2 days
-
Bug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 4 days
-
needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
spectreconsole/spectre.console#2221 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
godotengine/godot-docs#12428 ·
Maintainers usually reply within 1 day