LSP cleanup on uninstall ignores recorded LSP targets and fails with 'No harness detected'

Open Beginner friendly
#4,059 1 comment 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
75/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
python
Domain
cli, devtools

Research direction

Start in install/lsp/integration.py and trace the uninstall cleanup path that chooses LSP targets. Compare its target resolution with the recorded lsp_target_servers in the lockfile and the apm install --target copilot case described here. Done when cleanup uses the recorded targets and succeeds without targets: or a harness signal; check the relevant lifecycle tests.

Written by the indexing model from the issue text.

Description

bug status/accepted

LSP cleanup on uninstall resolves targets from apm.yml targets: and harness detection instead of the recorded lsp_target_servers in the lockfile. A project installed only with apm install --target copilot (no targets:, no harness signal) therefore fails LSP cleanup with 'No harness detected'. Cleanup should use the targets APM recorded when it wrote the LSP entries. Owner: install/lsp/integration.py (lsp-lifecycle). Found while fixing #4045 (PR #4057).

Dominant language
Python
Stars
4.4k
Forks
430
Avg merge
1d 22h
Merged PRs (30d)
285

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from microsoft/apm

All issues in microsoft/apm

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.