COM reference leak?
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 38/100
Research direction
Start at VirtualCamera/VirtualCameraMediaSource/SimpleMediaSource.cpp line 37 and inspect how the C++/WinRT object is transferred into m_streamList[i]. Compare the WIL and C++/WinRT ownership at that point, then verify that the corrected ownership path no longer adds an unreleased COM reference.
Written by the indexing model from the issue text.
Description
Hi,
Hi think there's a COM reference leak here
https://github.com/microsoft/Windows-Camera/blob/master/Samples/VirtualCamera/VirtualCameraMediaSource/SimpleMediaSource.cpp#L37
auto ptr = winrt::make_self<SimpleMediaStream>(); // +1
m_streamList[i] = ptr.detach(); // +2
It's caused by the mix between WIL and C++/WinRT
This could be fixed by something like this for example:
m_streamList[i].attach(ptr.detach());
- Dominant language
- C#
- Stars
- 261
- Forks
- 81
- Avg merge
- 1m
- Merged PRs (30d)
- 1
Getting set up
We have not checked this project's setup files yet. Start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from microsoft/Windows-Camera
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
microsoft/Windows-Camera#69 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
microsoft/Windows-Camera#68 · 1 comment ·
All issues in microsoft/Windows-Camera
Similar issues
-
area-ai untriaged
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
dotnet/extensions#7790 ·
Maintainers usually reply within 1 day
-
P2 testing
Difficulty 1/5 Under an hour Newbie friendliness 90/100
Maintainers usually reply within 1 day
-
area-Infrastructure-coreclr os-ios os-maccatalyst os-tvos untriaged
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
dotnet/runtime#134766 · 3 comments ·
Maintainers usually reply within 1 day
-
0 - Backlog Bug
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
BrighterCommand/Brighter#4444 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Maintainers usually reply within 1 day