[Web API type definition issue] Node.parentElement has wrong type

Open
#2,021 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
48/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
typescript
Domain
api, tooling

Research direction

Reproduce the mismatch with the TypeScript Playground link and compare the related issue #2020 for context. Trace where the Web API type definition is generated, then verify that Node.parentElement is exposed as Element | null and that the relevant generator checks pass.

Written by the indexing model from the issue text.

Description

lib.d.ts bug
Summary

Node.parentElement has type HTMLElement | null but it should be Element | null

Expected vs. Actual Behavior

Expected: node.parentElement type to be Element | null
Actual: HTMLElement | null

Playground Link

https://www.typescriptlang.org/play/?#code/MYewdgzgLgBKZQIYEswFMBOMC8MAmIwArgLZoIB0wGaiUaAogDZpkIAUA5HsgG6cBKAFDwkqTBVToMACQAqAWQAyOGJwA8EXgHMAfOr3qA9IaNa9nISPDQY21aJTSKAM2QZozVuSgBhABbITHgAhK7unixsfoHBMIgQMADKAGoA4mle0VbwECAsFEwg2uzaFAAOiDQIWT4wqNCIYMBoIC7J6bUIAjBGRjBQGERoMDk2sNoATKplldVQXbAJHZlRPmOQ+WiFxaXTDUjNre2pq97dvf2ITHkDQ2hCQA

Browser Support
  • This API is supported in at least two major browser engines (not two Chromium-based browsers).
Have Tried The Latest Releases
  • This issue applies to the latest release of TypeScript.
  • This issue applies to the latest release of @types/web.
Additional Context

Proof: run the example in the playground.

Similar to:

Dominant language
TypeScript
Stars
740
Forks
474
Avg merge
2d 8h
Merged PRs (30d)
15

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from microsoft/TypeScript-DOM-lib-generator

All issues in microsoft/TypeScript-DOM-lib-generator

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.