GlobalEventHandlersEventMap "command" mapped incorrectly

Open Beginner friendly
#2,554 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
74/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
typescript
Domain
api, tooling

Research direction

Locate GlobalEventHandlersEventMap in the generator inputs and inspect the existing event-map tests. Compare the command event mapping with the MDN CommandEvent reference, update the mapping, then run the relevant generator and tests to verify that generated declarations type command handlers correctly.

Written by the indexing model from the issue text.

Description

Command events fire a CommandEvent, however they are currently mapped to the basic Event interface.

Ref:
https://developer.mozilla.org/en-US/docs/Web/API/CommandEvent/command

At the moment, I need to assert or put a guard clause to get correct typing inside a command event handler. Please update the type mapping under GlobalEventHandlersEventMap.

Dominant language
TypeScript
Stars
740
Forks
474
Avg merge
2d 8h
Merged PRs (30d)
15

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from microsoft/TypeScript-DOM-lib-generator

All issues in microsoft/TypeScript-DOM-lib-generator

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.