Missing specific subclass type definitions in StylePropertyMapReadOnly.get() return type

Open
#1,863 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
25/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
typescript
Domain
tooling

Research direction

Start by locating the generator code that defines StylePropertyMapReadOnly.get() and reviewing the CSS Typed OM specification types named in the issue. Compare the generated return type with the property-specific subclasses, then validate that the generated TypeScript declarations narrow correctly for representative CSS property names.

Written by the indexing model from the issue text.

Description

Currently, StylePropertyMapReadOnly.get() returns undefined | CSSStyleValue for all CSS properties. This doesn't reflect the CSS Typed OM specification where different properties return specific subclasses like CSSUnitValue, CSSKeywordValue, and CSSTransformValue.

I have a PR ready that addresses this by narrowing down the return types based on property names.

Dominant language
TypeScript
Stars
740
Forks
474
Avg merge
2d 8h
Merged PRs (30d)
15

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from microsoft/TypeScript-DOM-lib-generator

All issues in microsoft/TypeScript-DOM-lib-generator

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.