onerror for Elements is incorrect

Open
#1,821 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
38/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
typescript
Domain
tooling

Research direction

Reproduce the type error in the linked TypeScript playground and compare the Window.onerror and element onerror signatures against the linked MDN documentation. Locate the DOM library generator input or test covering GlobalEventHandlers, then update the element signature and verify that the example accepts an Event callback without changing Window.onerror.

Written by the indexing model from the issue text.

Description

const img = document.createElement('img')

// type error:
img.onerror = (e: Event) => e
Screenshot 2024-10-07 at 8 03 39 PM

playground

Only Window.onerror should have the alternative signature, but not elements. See:

Dominant language
TypeScript
Stars
740
Forks
474
Avg merge
2d 8h
Merged PRs (30d)
15

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from microsoft/TypeScript-DOM-lib-generator

All issues in microsoft/TypeScript-DOM-lib-generator

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.