NotificationOptions is missing actions option

Open
#1,725 9 comments 12 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
72/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
typescript
Domain
web-dev

Research direction

Start with the NotificationOptions definitions in baselines/dom.generated.d.ts and baselines/serviceworker.generated.d.ts, then compare them with the WHATWG NotificationOptions specification and the linked MDN documentation. Trace how these generated declarations are produced, add the missing actions, timestamp, and renotify options in the appropriate source, and regenerate or update both baselines.

Written by the indexing model from the issue text.

Description

Hey,

I noticed that the NotificationOptions definition doesn't include the actions option. This is the current definition: dom.generated.d.ts and serviceworker.generated.d.ts

Here is the relevant mdn link.

In addition, timestamp and renotify are also missing.

This might be an regression of #438, but I am not sure.

Dominant language
TypeScript
Stars
740
Forks
474
Avg merge
2d 8h
Merged PRs (30d)
15

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from microsoft/TypeScript-DOM-lib-generator

All issues in microsoft/TypeScript-DOM-lib-generator

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.