Node.parentElement should be Element, not HTMLElement

Open
#1,706 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
45/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
typescript
Domain
tooling

Research direction

Start by reading the generated declaration in lib.dom.d.ts and compare Node.parentElement with the linked DOM specification and reverted commit. Trace the generator source that produces this declaration, then verify that regeneration emits Element | null and that the generated output remains consistent.

Written by the indexing model from the issue text.

Description

In lib.dom.d.ts Node.parentElement is defined as being HTMLelement | null. However, it should Element | null. The spec confirms this. This issue was originally fixed by #885 but was reverted in https://github.com/microsoft/TypeScript-DOM-lib-generator/commit/c81fa761df9c4483cd7f5d9767415660d4f1ee90. I didn't see any reasoning attached to that revert commit and the typing is still incorrect after the revert.

Dominant language
TypeScript
Stars
740
Forks
474
Avg merge
2d 8h
Merged PRs (30d)
15

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from microsoft/TypeScript-DOM-lib-generator

All issues in microsoft/TypeScript-DOM-lib-generator

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.