UpdateSpecification.AcceptChildren issue results in out of sequence explicit visit calls

Open

#84 opened on May 18, 2024 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty: 4/5
Estimated time: 3-5 days
Newbie friendliness: 35/100

Issue type: Bug
Clarity: Mostly clear
Activity status: Stale
Tech stack: sql
Domain: databases

Research direction

Start by reproducing the visitor with ExplicitVisit overrides for AssignmentSetClause and WhereClause on .NET 8, then inspect the traversal behavior of those AST nodes. Done means the explicit visits occur in the expected statement order, with a regression test demonstrating the result.

Written by the indexing model from the issue text.

Description

bug

SqlPackage or DacFx Version:
.NET Framework (Windows-only) or .NET Core: .NET 8
Environment (local platform and source/target platforms): net8.0-windows x64

Steps to Reproduce:

Create a visitor inheriting from TSqlFragmentVisitor
Override ExplicitVisit(AssignmentSetClause node)
Override ExplicitVisit(WhereClause node)
Item 2. (AssignmentSetClause) gets invoked "after" Item 3. (WhereClause)
Shouldn't this be reversed?

Did this occur in prior versions? If not - which version(s) did it work in?

(DacFx/SqlPackage/SSMS/Azure Data Studio)

Dominant language: GAP
Stars: 277
Forks: 43
Avg merge: 6d 17h
Merged PRs (30d): 3

Contributor guide

Open the contributing guide

First steps

Read the whole issue, then the project's contributing guide.
Comment on the issue to say you are picking it up — it saves two people doing the same work.
Fork the repository and make your change on a branch.
Open a pull request that references the issue number.

Similar issues

[Bug report] iceberg rest server load_table with refs fails precondition check "Cannot set metadata location with changes to table metadata: %s changes" for snapshots with statistics Open

bug

Difficulty 2/5 1-3 hours Newbie friendliness 85/100

apache/gravitino#13452 · Opened Sep 22, 2026
[BUG]: "Clear All" in Settings doesn't clear the saved analysis, old data comes back after reload Open

bug

Difficulty 2/5 1-3 hours Newbie friendliness 88/100

AOSSIE-Org/OrgExplorer#253 · 1 comment · Opened Sep 22, 2026
doltlite_vtab_vc_matrix.sh asserts the pre-merge state after a clean merge, so a refused merge passes Open

enhancement

Difficulty 2/5 1-3 hours Newbie friendliness 88/100

dolthub/doltlite#3163 · Opened Sep 22, 2026
[receiver/oracledb] db.system.name emits "oracle" instead of the semconv value "oracle.db" Open

needs triage receiver/oracledb

Difficulty 2/5 1-2 days Newbie friendliness 84/100

open-telemetry/opentelemetry-collector-contrib#51400 · 1 comment · Opened Sep 22, 2026
Default properties (especially URLs) have the wrong type: string instead of url Open

Difficulty 2/5 1-3 hours Newbie friendliness 78/100

logseq/db-test#1264 · Opened Sep 22, 2026

More Databases issues