NotLike should not be a BooleanComparisonType

Open Beginner friendly
#183 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
62/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
sql
Domain
databases

Research direction

Start by locating the BooleanComparisonType definition and reviewing change #158, then trace how the random query generator consumes that list. The work is done when the comparison classification matches the issue's stated LIKE behavior and the generator no longer encounters unexpected (Not)Like predicates there.

Written by the indexing model from the issue text.

Description

The change #158 added NotLike to the list of BooleanComparisonType.
However, LIKE is not part of that list, so neither should NotLike.

This is causing issues in our random query generator, since it is not expecting (Not)Like predicates in that list.

Dominant language
GAP
Stars
277
Forks
43
Avg merge
6d 17h
Merged PRs (30d)
3

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from microsoft/SqlScriptDOM

All issues in microsoft/SqlScriptDOM

Similar issues

More Databases issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.