async version of `Microsoft.SqlServer.TransactSql.ScriptDom.TSqlFragmentVisitor`

Open

#19 opened on Sep 30, 2021 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty: 5/5
Estimated time: Over a week
Newbie friendliness: 25/100

Issue type: Feature
Clarity: Mostly clear
Activity status: Stale
Tech stack: csharp, sql
Domain: devtools

Research direction

Start by reading the TSqlFragmentVisitor and TSqlFragment APIs named in the issue, along with their existing synchronous visit and accept methods. Determine the full set of visitor and fragment methods that would need asynchronous counterparts, then verify that asynchronous traversal supports the requested SQL work without changing synchronous behavior.

Written by the indexing model from the issue text.

Description

enhancement

I extensively use Microsoft.SqlServer.TransactSql.ScriptDom.TSqlFragmentVisitor to validate my queries against my DB schema, and in literally every of its method I need to execute some SQL queries (e.g. CreateCommand + ExecuteReader)

To make my code more modern, I want to use async methods (e.g. CreateCommand + ExecuteReaderAsync), so I need to have the following methods because these methods are above on my stack:

public abstract class TSqlFragmentVisitor
{
   public virtual Task ExplicitVisitAsync(FederationScheme node);
}

and

public abstract class TSqlFragment
{
        public virtual Task AcceptAsync(TSqlFragmentVisitor visitor);
        public virtual Task AcceptChildrenAsync(TSqlFragmentVisitor visitor);

}

Please consider to add these methods.

Thank you!

Dominant language: GAP
Stars: 277
Forks: 43
Avg merge: 6d 17h
Merged PRs (30d): 3

Contributor guide

Open the contributing guide

First steps

Read the whole issue, then the project's contributing guide.
Comment on the issue to say you are picking it up — it saves two people doing the same work.
Fork the repository and make your change on a branch.
Open a pull request that references the issue number.

Similar issues

[Bug]: SSH host picker duplicates configured aliases and known_hosts targets Open

Difficulty 2/5 1-3 hours Newbie friendliness 75/100

pingdotgg/t3code#13270 · Opened Sep 23, 2026
aspire run --isolated still collides on the resource-service port (22142) across worktrees Open

Difficulty 2/5 1-3 hours Newbie friendliness 75/100

nightscout/nocturne#1424 · Opened Sep 23, 2026
A claim comment carrying the issue number is silently declined while the workflow reports success Open

area: repo bug perceived difficulty: 2

Difficulty 2/5 1-3 hours Newbie friendliness 70/100

Nitjsefnie-Harness-Commons/daedalus#926 · Opened Sep 23, 2026
impl detach for native Open

Difficulty 2/5 1-3 hours Newbie friendliness 65/100

paritytech/zombienet-sdk#591 · Opened Sep 23, 2026
board_lifecycle.audit_findings raises GhError with one argument — a TypeError at raise time (hidden until FEAT-64) Open

bug

Difficulty 2/5 1-3 hours Newbie friendliness 75/100

mruangutai/harness#1897 · Opened Sep 23, 2026

More DevTools issues