Hacktoberfest 2026: the issues maintainers tagged for October, open and beginner-friendly. Browse Hacktoberfest issues

Consider returning specifically TSQLScript object from parser instead of abstraction

Open
#139 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
csharp, sql
Domain
api, compilers

Research direction

Start with the top parse method in SqlScriptDom/Parser/TSql/TSqlParser.cs and the internal parse method in TSql150Parser.cs, as linked in the issue. Trace their return types and the HotSwap method's handling of the result. Done means the parser exposes the concrete TSQLScript result consistently, so consumers do not need a hard cast.

Written by the indexing model from the issue text.

Description

Since you know specfically that the result is TSQLScript why turning it into a less comfortable to work with abstraction for consumers?

Image
top parse method

Image
internal parse method

To start working with TSQLScript and his batches one has to double-check or to perform a hard cast to TSQLScript just as you do in HotSwap method - why? Since it always was a TSQLScript instance.

Dominant language
GAP
Stars
277
Forks
43
Avg merge
6d 17h
Merged PRs (30d)
3

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from microsoft/SqlScriptDOM

All issues in microsoft/SqlScriptDOM

Similar issues

More Backend & API Design issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.