A typed visitor would be nice

Open

#123 opened on Mar 10, 2025 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty: 5/5
Estimated time: Over a week
Newbie friendliness: 35/100

Issue type: Feature
Clarity: Mostly clear
Activity status: Stale
Tech stack: sql
Domain: compilers, databases

Research direction

Start by locating the existing ISqlCodeObjectVisitor interface and the visitor implementations exposed by SqlScriptDom. Compare their Visit() methods and determine how a generic return type could cover the AST; done means a documented typed visitor API supports expression parsing without breaking the existing void visitor behavior.

Written by the indexing model from the issue text.

Description

I'm trying to convert a project over from SqlParser, because SqlParser lacks support for some things I'm trying to parse and it doesn't have source available. But I've hit a roadblock: SqlScriptDom doesn't have anything analogous to ISqlCodeObjectVisitor<T>, which allows you to create visitors where every Visit() method returns T rather than void. It's incredibly useful for things like parsing expressions.

Would it be possible to add a typed visitor to SqlScriptDom?

Dominant language: GAP
Stars: 277
Forks: 43
Avg merge: 6d 17h
Merged PRs (30d): 3

Contributor guide

Open the contributing guide

First steps

Read the whole issue, then the project's contributing guide.
Comment on the issue to say you are picking it up — it saves two people doing the same work.
Fork the repository and make your change on a branch.
Open a pull request that references the issue number.

Similar issues

isolated-declarations: TS9025 on an optional parameter property typed `readonly T[]`, which tsc 7 accepts Open

Difficulty 2/5 1-3 hours Newbie friendliness 88/100

oxc-project/oxc#26944 · Opened Sep 22, 2026
perf: a definite-value return type (`--> Nil`, `--> True`) sends every call down the full path (~12 µs vs ~1 µs) Open

todo:perf

Difficulty 2/5 1-3 hours Newbie friendliness 84/100

tokuhirom/mutsu#9074 · Opened Sep 22, 2026
A function-call exponent (`A^sqrt(n)`) emits `pow(A, sqrt)(n)` — valid BNGL that codegen cannot compile Open

bug

Difficulty 2/5 Half a day Newbie friendliness 82/100

lanl/bngsim#657 · Opened Sep 22, 2026
tt_metal/hw/inc/internal/tt-2xx/quasar/overlay/xcustom_test.hpp needs reimplementing Open

Difficulty 2/5 1-3 hours Newbie friendliness 68/100

tenstorrent/tt-metal#57393 · 1 comment · Opened Sep 22, 2026
StUnhex.number() misformats Long.MIN_VALUE as scientific notation instead of a plain integer Open

Difficulty 2/5 1-3 hours Newbie friendliness 86/100

objectionary/eo#8894 · Opened Sep 22, 2026

More Compilers issues